On Sat, Jul 17, 2021 at 1:46 PM Niels Möller nisse@lysator.liu.se wrote:

Maamoun TK maamoun.tk@googlemail.com writes:

...

It fits better to have one implementation per key size, I'll modify this patch to apply this approach. However, we need to merge the s390x branch

at

...

first since it has a separate implementation for each key size.

Right. With fat support in, is there anything else that is essential before merging?

No, AES and GHASH have the full functionalities for S390x architecture in this way.