nettle-bugs November 2013

nettle-bugs@lists.lysator.liu.se

9 participants
10 discussions

[PATCH 1/5] Don't include OPT_ASM_SOURCES twice in hogweed_PURE_OBJS
by Martin Storsjö 24 Aug '14

24 Aug '14

OPT_ASM_SOURCES is already included via hogweed_OBJS. This avoids build errors about duplicate symbols in the shared library. --- Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.in b/Makefile.in index 1ec807b..2db76c5 100644 --- a/Makefile.in +++ b/Makefile.in @@ -180,7 +180,7 @@ nettle_OBJS = $(nettle_SOURCES:.c=.$(OBJEXT)) $(LIBOBJS) nettle_PURE_OBJS = $(nettle_OBJS:.$(OBJEXT)=.p$(OBJEXT)) hogweed_OBJS = $(hogweed_SOURCES:.c=.$(OBJEXT)) $(OPT_ASM_SOURCES:.asm=.$(OBJEXT)) -hogweed_PURE_OBJS = $(hogweed_OBJS:.$(OBJEXT)=.p$(OBJEXT)) $(OPT_ASM_SOURCES:.asm=.p$(OBJEXT)) +hogweed_PURE_OBJS = $(hogweed_OBJS:.$(OBJEXT)=.p$(OBJEXT)) libnettle.a: $(nettle_OBJS) -rm -f $@ -- 1.7.9.4

5 29

brainpool curves
by Nikos Mavrogiannopoulos 02 Feb '14

02 Feb '14

Hello, There has been lately an attempt to avoid the NIST's curves due to suspicions about their generation. One of them are the brainpool curves at: http://tools.ietf.org/html/rfc5639 which seem to be sponsored by the German BSI. Having them in nettle would be a good thing (the same authors are working on standardizing these curves in TLS and PKIX). regards, Nikos

5 7

Release plans
by nisse＠lysator.liu.se 22 Jan '14

22 Jan '14

I have updated the release plans, at http://www.lysator.liu.se/~nisse/nettle/plan.html. I aim to get a release out within a month or two. Regards, /Niels -- Niels Möller. PGP-encrypted email is preferred. Keyid C0B98E26. Internet email is subject to wholesale government surveillance.

3 26

Re: Nettle-2.7.1 with static GMP error
by nisse＠lysator.liu.se 30 Nov '13

30 Nov '13

Alexey Pavlov <alexpux(a)gmail.com> writes: > 2013/11/29 Niels Möller <nisse(a)lysator.liu.se>: >> What failed? Can I repost your message to the list? > > I do it already. I receive subscribing message now. Ok. I'm now cc:ing the list. Context: Link error when building a dynamic libnettle.dll and libhogweed.dll, and statically linking to libgmp.a. >>> i686-w64-mingw32-gcc -march=i686 -mtune=generic -O2 -pipe >>> -I/mingw32/include -ggdb3 -Wno-pointer-sign -Wall -W >>> -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes >>> -Wpointer-arith -Wbad-function-cast -Wnested-externs -L.. -pipe >>> -L/mingw32/lib ecc-mod-test.o testutils.o ../nettle-internal.o >>> -lhogweed -lnettle -lgmp -o ecc-mod-test.exe >>> >>> C:/msys64/mingw32/lib/libgmp.a(sub_n.o):(.text+0x0): multiple >>> definition of `__gmpn_sub_n' >>> >>> ../libhogweed.dll.a(d000131.o):(.text+0x0): first defined here >>> >>> collect2.exe: error: ld returned 1 exit status >> >> So you're building shared libraries for nettle, but you have a static >> gmp library? The way I understand the error, the used gmp functions gets >> copied into libhogweed.dll. Not sure if that is the best behavior. >> > Yes I have static GMP because we build toolchains with static > prerequisites and don't want to has dynamic dependencies from them > (gmp, mpc, mpfr, clog, isl). I prefer to use static versions of them. >> But I'm not sure I understand the link error. There's some function >> depending on __gmpn_sub_n ("mpn_sub_n" to user code), but if that >> function is included in libhogweed.dll, why isn't that function just >> skipped when the linker processes libgmp.a? > > A program in C can have only one definition (declaration which assigns > a value) for each object (storage space for a variable). But when doing linking with static libraries, multiple definitions are generally ok. The linker copies only the object files which are needed, and when it needs a symbol, it includes only the first object file in any of the libraries, which define the symbol. One may still get clashes if each object file includes multiple symbols, since in the set of object files selected by the linker in the end, multiple definitions of the same symbol are not allowed. > As I understand, somewhere header file contains definitions for > several functions __gmpn_sub_n which when included in several > different translation units results in the linker throwing this error. I don't think so. My understanding is that 1. The symbol __gmp_sub_n is defined in some object file included in libgmp.a, and nowhere in the nettle source or object code (and mini-gmp.c doesn't count, it's not involved in the link, and it uses different linker symbol names than the real gmp). 2. This object file gets copied from libgmp.a into libhogweed.dll by the linker. Not sure if this is right; -lgmp was added to the libhogweed link command primarily to get dependencies between *shared* libraries right. 3. You then link the executable ecc-mod-test.exe with -lhogweed and -lgmp. The linked sees two definitions of the symbol __gmpn_sub_n, one in libgmp.a, and one in libhogweed.dll, and it considers this an error. What I don't understand, is why, in (3) above, the linker doesn't just ignore the object in libgmp.a which defines the symbol. Regards, /Niels -- Niels Möller. PGP-encrypted email is preferred. Keyid C0B98E26. Internet email is subject to wholesale government surveillance.

2 3

Building nettle-2.7.1 with static GMP bug
by Alexey Pavlov 29 Nov '13

29 Nov '13

Hi! I'm try to build nettle-2.7.1 with static GMP with mingw-w64 toolchain GCC-4.8.2 and got error while linking with static GMP: i686-w64-mingw32-gcc -march=i686 -mtune=generic -O2 -pipe -I/mingw32/include -ggdb3 -Wno-pointer-sign -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wbad-function-cast -Wnested-externs -L.. -pipe -L/mingw32/lib ecc-mod-test.o testutils.o ../nettle-internal.o -lhogweed -lnettle -lgmp -o ecc-mod-test.exe C:/msys64/mingw32/lib/libgmp.a(sub_n.o):(.text+0x0): multiple definition of `__gmpn_sub_n' ../libhogweed.dll.a(d000131.o):(.text+0x0): first defined here collect2.exe: error: ld returned 1 exit status /msys_repo/mingw-w64-nettle/src/nettle-2.7.1/testsuite/.test-rules.make:167: recipe for target 'ecc-mod-test.exe' failed make[1]: *** [ecc-mod-test.exe] Error 1 Is any fix for this? Regards, Alexey.

1 0

Apparent bug in SHA-1 digests
by Paul Tagliamonte 27 Nov '13

27 Nov '13

Hey hackers, I'm seeing some behavior that confuses me a bit. I'm sure I'm doing something wrong, but I can't tell. Here's a minimal example: / | #include <stdio.h> | #include <nettle/rsa.h> | | int main ( int argc, char ** argv ) { | struct sha1_ctx hash_ctx; | uint8_t headers[] = { | 0xDE, 0xEA, 0xAD, | 0xBE, 0xEF | }; | sha1_update(&hash_ctx, 5, headers); | | for (int i = 0; i < 3; ++i) { | uint8_t _fingerprint[SHA1_DIGEST_SIZE]; | sha1_digest(&hash_ctx, SHA1_DIGEST_SIZE, _fingerprint); | for (int i = 0; i < SHA1_DIGEST_SIZE; ++i) | printf("%02X ", _fingerprint[i]); | printf("\n"); | } | } \ The output, when run is: / | 89 22 AA 95 F2 02 C9 BB 35 FC 2D A2 DE 22 BE 48 2B B6 6C 1D | DA 39 A3 EE 5E 6B 4B 0D 32 55 BF EF 95 60 18 90 AF D8 07 09 | DA 39 A3 EE 5E 6B 4B 0D 32 55 BF EF 95 60 18 90 AF D8 07 09 \ (that last line is stable after the inital hash) Does doing the sha1_digest alter state in some way? I can't image it is, but then how does this behavior crop up? Much love, thanks all! Cheers, Paul -- #define sizeof(x) rand() :wq

3 2

poly1305 nonce increments
by nisse＠lysator.liu.se 21 Nov '13

21 Nov '13

As I wrote, I'm working with poly1305. One question: The _digest function will update the nonce value, so that by default one gets a nonce sequence of 0, 1, 2, .... In the code I'm working with (contributed by Nikos), this increment is done in a big-endian fashion, just like increments for CTR mode. Is this going to be the common way to generate nonces for poly1305? Regards, /Niels -- Niels Möller. PGP-encrypted email is preferred. Keyid C0B98E26. Internet email is subject to wholesale government surveillance.

2 2

Make error on CentOS 6.4 x64
by Martin Lambev 16 Nov '13

16 Nov '13

Hello nettle gurus, I'm trying to build GnuTLS 3.2.6 on CentOS 6.4 x64, but having some issues with nettle during compilation. nettle 2.7.1 make errors: configure: summary of build options: Version: nettle 2.7.1 Host type: x86_64-unknown-linux-gnu ABI: 64 Assembly files: x86_64 Install prefix: /usr/local Library directory: ${exec_prefix}/lib64 Compiler: gcc Static libraries: yes Shared libraries: yes Public key crypto: yes Documentation: no During "$ make" exits with error: hogweed-benchmark.c:575: error: ‘struct openssl_ctx’ has no member named ‘key’ hogweed-benchmark.c:576: error: ‘struct openssl_ctx’ has no member named ‘digest’ make[1]: *** [hogweed-benchmark.o] Error 1 make[1]: Leaving directory `/home/mve/Downloads/ocserv/nettle/nettle-2.7.1/examples' make: *** [all] Error 1 It fails "error: ‘struct openssl_ctx’" so I looked configure help options… $ make clean $ ./configure --help #give a few options so I disabled this one as I'm assuming it's not used in my case isn't it? $ ./configre --disable-openssl #Do not include openssl glue in the benchmark program after doing this "make" successfully finished and I can install "nettle" Is this proper workaround or not? If not how should be handed properly? Thank you! Regards, Martin

2 1

Re: undefined behaviors
by John Regehr 13 Nov '13

13 Nov '13

> I imagine you intended to mail the nettle-bugs list, rather than > nettle-bugs-owner administrative address? Feel free to reply on list. Ugh, sorry, cut and paste... > That's unexpected. Hmm. The NEWS file for 2.7.1 claims that this problem > was fixed in that release, but appearantly it wasn't. You can check if > the error disappears if you replace the definition of ROT32 in macros.h > by > > #define ROTL32(n,x) (((x)<<(n)) | ((x)>>((-(n)&31)))) I'll check this tonight. >> blowfish.c:353:19: runtime error: left shift of 244 by 24 places >> cannot be represented in type 'int' >> twofish.c:196:54: runtime error: left shift of 184 by 24 places cannot >> be represented in type 'int' > > These should have some casts to uint32_t, I think. Unlikely to cause > real problems. Right, I don't know of any compiler that exploits these, and in fact in C++ (but not C) this particular case is covered by a defect report that makes it defined. Thanks, John

2 4

added functions to zeroize
by Nikos Mavrogiannopoulos 13 Nov '13

13 Nov '13

Hello, Attached is a patch that allows overwriting values (points and scalars) in the ECC API. regards, Nikos

2 4

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

nettle-bugs November 2013