nettle-bugs September 2012

nettle-bugs@lists.lysator.liu.se

4 participants
8 discussions

[PATCH] silence more warnings
by Tim Ruehsen 21 Dec '12

21 Dec '12

some little fixes for nettle-hash.c:53:2: warning: ISO C does not allow extra ';' outside of a function [-pedantic] testutils.c:1072:2: warning: ISO C does not allow extra ';' outside of a function [-pedantic] des-compat-test.c:748:14: warning: old-style function definition [-Wold-style-definition] des-compat-test.c:755:17: warning: initialization discards 'const' qualifier from pointer target type [enabled by default] Regards, Tim diff --cc testsuite/des-compat-test.c index 257c343,257c343..4021ee8 --- a/testsuite/des-compat-test.c +++ b/testsuite/des-compat-test.c @@@ -745,14 -745,14 +745,13 @@@ plain[8+4], plain[8+5], plain[8+6], pla return(0); } --static char *pt(p) --const unsigned char *p; ++static char *pt(const unsigned char *p) { static char bufs[10][20]; static int bnum=0; char *ret; int i; -- static char *f="0123456789ABCDEF"; ++ static const char *f="0123456789ABCDEF"; ret= &(bufs[bnum++][0]); bnum%=10; diff --cc testsuite/testutils.c index d77bb7e,d77bb7e..1b0fd88 --- a/testsuite/testutils.c +++ b/testsuite/testutils.c @@@ -1069,7 -1069,7 +1069,7 @@@ test_dsa_key(struct dsa_public_key *pub mpz_powm(t, pub->g, key->x, pub->p); ASSERT(0 == mpz_cmp(t, pub->y)); --}; ++} #endif /* WITH_HOGWEED */ diff --cc tools/nettle-hash.c index 842f9ff,5710216..bd03b18 --- a/tools/nettle-hash.c +++ b/tools/nettle-hash.c @@@ -50,9 -49,9 +50,9 @@@ list_algorithms (void for (i = 0; (alg = nettle_hashes[i]); i++) printf ("%10s %d (%d)\n", alg->name, alg->digest_size, alg->block_size); --}; ++} -static const struct nettle_hash * +static const struct nettle_hash * NONNULL(1) find_algorithm (const char *name) { const struct nettle_hash *alg;

2 1

Salsa20/8 and Salsa20/12
by Simon Josefsson 28 Nov '12

28 Nov '12

I quickly discovered that I needed the round-reduced variants of Salsa20. Here they are. I didn't update the assembler part, so I would need help finishing that part. /Simon

3 17

gost hash
by Nikos Mavrogiannopoulos 11 Nov '12

11 Nov '12

[this is a resend, sorry if you received it multiple times] Hello, The attached patch adds the GOST R 34.11-94 hash algorithm. I based this code on Alexei Kravchenko's code from librhash. The original code [0] had inline assembly for x86 and x86-64 which is removed from this version. Although this is not a modern algorithm it is being used in the russian digital signature standard (GOST R 34.11-2001). I had issue making the test gost94-test compile. For some reason the makefile wouldn't link it against gmp (all the other tests were ok), and couldn't figure out why. regards, Nikos [0]. http://hg.splayer.org/splayer/src/5027d6aa04f1/Thirdparty/librhash/librhash/

3 16

gost hash
by Nikos Mavrogiannopoulos 25 Sep '12

25 Sep '12

Hello, The attached patch adds the GOST R 34.11-94 hash algorithm. I based this code on Alexei Kravchenko's code from librhash. The original code [0] had inline assembly for x86 and x86-64 which is removed from this version. Although this is not a modern algorithm it is being used in the russian digital signature standard (GOST R 34.11-2001). I had issue making the test gost94-test compile. For some reason the makefile wouldn't link it against gmp (all the other tests were ok), and couldn't figure out why. regards, Nikos [0]. http://hg.splayer.org/splayer/src/5027d6aa04f1/Thirdparty/librhash/librhash/

1 0

Salsa20 core
by Simon Josefsson 23 Sep '12

23 Sep '12

I realized that I didn't have any use for the round-reduced Salsa20 stream functions. So I'll focus on what I needed instead, which resulted in a much smaller patch. What do you think? Open issues: * I'm not particular happy about the name SALSA20_CORE_INOUT_SIZE. * Where could this be documented in the manual? "Miscellaneous functions"? We could also create a new section "Non-cryptographic Hash functions". There is the FNV and CRC hashes that could be implemented under that umbrella. /Simon

2 19

[PATCH] PKCS #5 PBKDF2
by Simon Josefsson 21 Sep '12

21 Sep '12

How about adding KDFs? Here is a starting pointer for the most common function, PKCS #5 PBKDF2. Review appreciated. /Simon

2 27

[PATCH] some patches to fix compiler warnings
by Tim Ruehsen 19 Sep '12

19 Sep '12

Some things I fixed, when having a look at the sources. Just two points for code reviewing: 1. #define NONNULL(...) __attribute__ ((nonnull(__VA_ARGS__))) is contains a C99 feature (...), but there are also C99 long long constants somewhere in the code (if you mind C89 compliancy). 2. In cast128.c I removed the wiping of t, l and r. Instead I set t=0 at the beginning of the loops (It seemed to be used uninitialized in F1 macro). Please just have a short look into it - maybe the "wiping" has some undocumented deeper meaning !? Regards, Tim

4 29

Three tests can't be created
by Tim Ruehsen 13 Sep '12

13 Sep '12

Hi, there are three tests which cannot be build from source: testsuite/sexp-conv-test testsuite/symbols-test testsuite/pkcs1-conv-test If you remove them the following fails: make clean make make check Making check in testsuite make[1]: Entering directory `/usr/oms/src/nettle/testsuite' make[1]: *** No rule to make target `sexp-conv-test', needed by `check'. Stop. These three binaries are in the git repository ... what's that ? Shouldn't there be sources a possibility to build the binaries ? Regards ,Tim

2 2

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

nettle-bugs September 2012