Hello,
Two small fixes to go on top of ecc-gost branch. These two patches can be squashed into respective patches or just live as separate instances, whatever you would prefer.
From: Dmitry Baryshkov dbaryshkov@gmail.com
Signed-off-by: Dmitry Baryshkov dbaryshkov@gmail.com --- ecc-gost-gc512a.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/ecc-gost-gc512a.c b/ecc-gost-gc512a.c index 4baec1f5945d..6d210925b609 100644 --- a/ecc-gost-gc512a.c +++ b/ecc-gost-gc512a.c @@ -43,7 +43,7 @@ #include "ecc-gost-gc512a.h"
static void -ecc_gc512a_modp (const struct ecc_modulo *m, mp_limb_t *rp) +ecc_gost_gc512a_modp (const struct ecc_modulo *m, mp_limb_t *rp) { mp_size_t mn = m->size; mp_limb_t hi; @@ -54,8 +54,8 @@ ecc_gc512a_modp (const struct ecc_modulo *m, mp_limb_t *rp) assert(hi == 0); }
-#define ecc_gc512a_modp ecc_gc512a_modp -#define ecc_gc512a_modq ecc_mod +#define ecc_gost_gc512a_modp ecc_gost_gc512a_modp +#define ecc_gost_gc512a_modq ecc_mod
const struct ecc_curve _nettle_gost_gc512a = { @@ -73,8 +73,8 @@ const struct ecc_curve _nettle_gost_gc512a = ecc_redc_ppm1,
ecc_pp1h, - ecc_gc512a_modp, - ecc_gc512a_modp, + ecc_gost_gc512a_modp, + ecc_gost_gc512a_modp, ecc_mod_inv, NULL, }, @@ -92,8 +92,8 @@ const struct ecc_curve _nettle_gost_gc512a = NULL, ecc_qp1h,
- ecc_gc512a_modq, - ecc_gc512a_modq, + ecc_gost_gc512a_modq, + ecc_gost_gc512a_modq, ecc_mod_inv, NULL, },
From: Dmitry Baryshkov dbaryshkov@gmail.com
Signed-off-by: Dmitry Baryshkov dbaryshkov@gmail.com --- .gitignore | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.gitignore b/.gitignore index 2e64c187574f..48e2b7f464da 100644 --- a/.gitignore +++ b/.gitignore @@ -45,8 +45,8 @@ core /rotors.h /ecc-curve25519.h /ecc-curve448.h -/ecc-gc256b.h -/ecc-gc512a.h +/ecc-gost-gc256b.h +/ecc-gost-gc512a.h /ecc-secp192r1.h /ecc-secp224r1.h /ecc-secp256r1.h
dbaryshkov@gmail.com writes:
Two small fixes to go on top of ecc-gost branch. These two patches can be squashed into respective patches or just live as separate instances, whatever you would prefer.
Pushed to that branch now.
Regards, /Niels
чт, 23 янв. 2020 г. в 17:06, Niels Möller nisse@lysator.liu.se:
dbaryshkov@gmail.com writes:
Two small fixes to go on top of ecc-gost branch. These two patches can be squashed into respective patches or just live as separate instances, whatever you would prefer.
Pushed to that branch now.
Thank you! What about GOST DSA v5 patches?
Dmitry Eremin-Solenikov dbaryshkov@gmail.com writes:
Thank you! What about GOST DSA v5 patches?
Look good, I'm trying them out right now, before leaving for the next airport. Running the benchmark, signing looks a bit faster than the ecdsa variants,
name size sign/ms verify/ms
ecdsa 256 3.0218 0.9877 ecdsa 521 0.7055 0.2278 gostdsa 256 3.7480 0.9381 gostdsa 512 0.9642 0.2403
The doc patch didn't apply cleanly, though,
Applying: Add documentation for GOSTDSA and GOST curves. error: corrupt patch at line 65 error: could not build fake ancestor
(I haven't looked into what the problem might be).
Regards, /Niels
Hello,
сб, 25 янв. 2020 г. в 18:23, Niels Möller nisse@lysator.liu.se:
Dmitry Eremin-Solenikov dbaryshkov@gmail.com writes:
Thank you! What about GOST DSA v5 patches?
Look good, I'm trying them out right now, before leaving for the next airport. Running the benchmark, signing looks a bit faster than the ecdsa variants,
name size sign/ms verify/ms ecdsa 256 3.0218 0.9877 ecdsa 521 0.7055 0.2278 gostdsa 256 3.7480 0.9381 gostdsa 512 0.9642 0.2403The doc patch didn't apply cleanly, though,
Applying: Add documentation for GOSTDSA and GOST curves. error: corrupt patch at line 65 error: could not build fake ancestor
(I haven't looked into what the problem might be).
This is strange. I have checked the e-mail from my 'sent' mailbox, it applies cleanly. Anyway, I have uploaded the diff to paste server. You can download and apply it: https://paste.debian.net/1127852/ . The download link is close to the bottom of the page.
Dmitry Eremin-Solenikov dbaryshkov@gmail.com writes:
This is strange. I have checked the e-mail from my 'sent' mailbox, it applies cleanly. Anyway, I have uploaded the diff to paste server. You can download and apply it: https://paste.debian.net/1127852/ . The download link is close to the bottom of the page.
Done! I also added two index entries.
Regards, /Niels
пн, 27 янв. 2020 г. в 17:26, Niels Möller nisse@lysator.liu.se:
Dmitry Eremin-Solenikov dbaryshkov@gmail.com writes:
This is strange. I have checked the e-mail from my 'sent' mailbox, it applies cleanly. Anyway, I have uploaded the diff to paste server. You can download and apply it: https://paste.debian.net/1127852/ . The download link is close to the bottom of the page.
Done! I also added two index entries.
Great, thank you!
I've sent two patches for next curve (the 256-bit 80000.....0c99 one) for review.
I still hope to get most curves into next release. I'm perfectly fine with releasing nettle without additional curves though.
Dmitry Eremin-Solenikov dbaryshkov@gmail.com writes:
I've sent two patches for next curve (the 256-bit 80000.....0c99 one) for review.
I still hope to get most curves into next release. I'm perfectly fine with releasing nettle without additional curves though.
I've now merged gostdsa and the first two curves to master.
I'd like to postpone additional gost curves for a bit, to figure out what else needs to get into the next release.
Regards, /Niels
Hello,
ср, 29 янв. 2020 г. в 07:14, Niels Möller nisse@lysator.liu.se:
Dmitry Eremin-Solenikov dbaryshkov@gmail.com writes:
I've sent two patches for next curve (the 256-bit 80000.....0c99 one) for review.
I still hope to get most curves into next release. I'm perfectly fine with releasing nettle without additional curves though.
I've now merged gostdsa and the first two curves to master.
Thank you!
I'd like to postpone additional gost curves for a bit, to figure out what else needs to get into the next release.
Fine with me, thank you!
nettle-bugs@lists.lysator.liu.se
-
dbaryshkov＠gmail.com -
Dmitry Eremin-Solenikov
-
nisse＠lysator.liu.se