I created a MR !31 https://git.lysator.liu.se/nettle/nettle/-/merge_requests/31 that adds fat build support of AES and GHASH for S390x architecture. The MR's description has a brief overview of the modifications done to add the fat build support.
regards, Mamone
Maamoun TK maamoun.tk@googlemail.com writes:
I created a MR !31 https://git.lysator.liu.se/nettle/nettle/-/merge_requests/31 that adds fat build support of AES and GHASH for S390x architecture. The MR's description has a brief overview of the modifications done to add the fat build support.
Merged, thanks! I wrote some comments asking for two followup changes (avoid inline asm, and setting of FAT_TEST_LIST).
Do you think we're getting ready to merge the s390x branch to master?
Regards, /Niels
On Sat, Jul 17, 2021 at 1:13 PM Niels Möller nisse@lysator.liu.se wrote:
Maamoun TK maamoun.tk@googlemail.com writes:
I created a MR !31 https://git.lysator.liu.se/nettle/nettle/-/merge_requests/31 that adds fat build support of AES and GHASH for S390x architecture. The MR's description has a brief overview of the modifications done to add the fat build support.
Merged, thanks! I wrote some comments asking for two followup changes (avoid inline asm, and setting of FAT_TEST_LIST).
Do you think we're getting ready to merge the s390x branch to master?
I've applied for your change requests. I think we're ready to merge the s390x branch at this point, let me know if there are conflicts with the master branch tho.
regards, Mamone
Maamoun TK maamoun.tk@googlemail.com writes:
I've applied for your change requests. I think we're ready to merge the s390x branch at this point, let me know if there are conflicts with the master branch tho.
Fixes merged, thanks!. I'll try out merging the s390x branch into master(-updates), to see if there are any difficulties.
Regards, /Niels
On Wed, Jul 21, 2021 at 6:11 PM Niels Möller nisse@lysator.liu.se wrote:
Maamoun TK maamoun.tk@googlemail.com writes:
I've applied for your change requests. I think we're ready to merge the s390x branch at this point, let me know if there are conflicts with the master branch tho.
Fixes merged, thanks!. I'll try out merging the s390x branch into master(-updates), to see if there are any difficulties.
Great! I intend to push SHA and CBC optimizations of s390x architecture to the s390x branch after being merged, it will be good to keep it in the repository. We also need a new branch after the s390x branch is merged to push AES optimizations of aarch64 into.
Maamoun TK maamoun.tk@googlemail.com writes:
I've applied for your change requests. I think we're ready to merge the s390x branch at this point, let me know if there are conflicts with the master branch tho.
Merged to master branch now! Had to commit some minor fixes to make "make dist" and the s390x ci build work, and added a brief ChangeLog entry for latest additions.
For the memxor merge requests, it would be good to retarget to the master branch (but I'm not sure how to do that in gitlab).
Regards, /Niels
regards, Mamone
On Sat, Jul 24, 2021 at 3:51 PM Niels Möller nisse@lysator.liu.se wrote:
Maamoun TK maamoun.tk@googlemail.com writes:
I've applied for your change requests. I think we're ready to merge the s390x branch at this point, let me know if there are conflicts with the master branch tho.
Merged to master branch now! Had to commit some minor fixes to make "make dist" and the s390x ci build work, and added a brief ChangeLog entry for latest additions.
For the memxor merge requests, it would be good to retarget to the master branch (but I'm not sure how to do that in gitlab).
I've edited the MR to target the master branch.
regards, Mamone
nettle-bugs@lists.lysator.liu.se
-
Maamoun TK -
nisse＠lysator.liu.se