On Sun, Jul 31, 2016 at 10:44 AM, Niels Möller nisse@lysator.liu.se wrote:
nisse@lysator.liu.se (Niels Möller) writes:
I think it should be easy and reasonable to add code to rsa_public_key_prepare and rsa_private_key_prepare to check that the modulo is odd. What do you think? It's reasonable to have those functions do enough key validation to be able to handle the key without crashing.
Done now (or rather, added to the shared helper function _rsa_check_size).
But where is this helper function used? As far as I see it is not used by rsa_pkcs1_verify() or similar functions, and it only applies if rsa_public_key_prepare() is used; otherwise the crash still applies. Gnutls for example doesn't use any of the *prepare functions.
regards, Nikos