On Wed, Mar 24, 2021 at 8:52 PM Niels Möller nisse@lysator.liu.se wrote:
Maamoun TK maamoun.tk@googlemail.com writes:
- S390X_SSH_IP_ADDRESS: username@instance_ip
- S390X_SSH_PRIVATE_KEY: private key of ssh connection
- S390X_SSH_CI_DIRECTORY: name of directory in remote server where the
tarball is extracted and tested
I made only the private key a variable (and of type "file", which means it's stored in a temporary file, with file name in $SSH_PRIVATE_KEY). The others are defined in the .gitlab-ci.yml file.
Isn't it better to define S390X_SSH_IP_ADDRESS variable rather than hard-code the remote server address in .gitlab-ci.yml? fresh forks now need to update .gitlab-ci.yml to get a S390x job which is a bit unwieldy in my opinion.
Update gitlab-ci.yml as follows:
- Add this line to variables category at the top of file:
DEBIAN_BUILD: buildenv-debian
I used the same fedora image as for the simpler build jobs.
Good.
only: variables: - $S390X_SSH_IP_ADDRESS - $S390X_SSH_PRIVATE_KEY - $S390X_SSH_CI_DIRECTORY
What does this mean? Ah, it excludes the job if these variables aren't set?
Yes, this is what it does according to gitlab ci docs https://docs.gitlab.com/ee/ci/yaml/#onlyexcept-basic. otherwise, fresh forks will have always-unsuccessful job.
regards, Mamone