Niels Möller nisse@lysator.liu.se writes:
Daiki Ueno ueno@gnu.org writes:
Sorry for the confusion and thank you for the explanation; now I get it. I pushed a change along the of option (2). Could you take a look again?
Thanks, looks good! Two nits, and let me know at which point you'd like to get it merged, and do further improvements as followup MRs.
Thank you; I have addressed those issues. As for the merging, I think it is ready now. I have also created a draft MR in GnuTLS to use the algorithm in PKCS#8, etc., so we can test the implementation in a broader context: https://gitlab.com/gnutls/gnutls/-/merge_requests/1805
Since the oaep.h header now only declares internal functions, it shouldn't be installed (moved from HEADERS to DISTFILES in Makefile.in).
And it would be nice if the manual could give some more detail about the label: As I understnd it, the label is optional, so it's fine to pass 0, NULL if not needed. And if used, the same label must be used for both encrypt and decrypt.
Regards,