27 Mar
2021
27 Mar
'21
3:07 a.m.
Maamoun TK maamoun.tk@googlemail.com writes:
Isn't it better to define S390X_SSH_IP_ADDRESS variable rather than hard-code the remote server address in .gitlab-ci.yml? fresh forks now need to update .gitlab-ci.yml to get a S390x job which is a bit unwieldy in my opinion.
Makes sense. I've added it as a variable, and renamed to S390X_ACCOUNT. Value is of the form username@ip-address.
Yes, this is what it does according to gitlab ci docs https://docs.gitlab.com/ee/ci/yaml/#onlyexcept-basic. otherwise, fresh forks will have always-unsuccessful job.
Ok, added a section
only: variables: - $SSH_PRIVATE_KEY - $S390X_ACCOUNT
Still on the master-updates branch, will merge as soon as the run looks green.
Regards, /Nies
--
Niels Möller. PGP-encrypted email is preferred. Keyid 368C6677.
Internet email is subject to wholesale government surveillance.