Daiki Ueno ueno@gnu.org writes:
That said, I agree that it would be more user friendly to combine them and treat it as a regular error, as we do in pss_encode_mgf1.
Thanks for the update, patch merged.
I noticed that there are two failures in the ci builds. See https://gitlab.com/gnutls/nettle/-/pipelines/1178451395.
One failure is the new side-channel test failing with mini-gmp. Which is expected, the test should just be skipped in mini-gmp builds (similar to several other sc tests).
The other is a complaint from ubsan. I guess it's related to the label == NULL case. I don't know what's the proper place for a fix, maybe it's not in the new code. I think the Nettle APIs should generally allow size == 0, ptr == NULL more or less everywhere, even where libc functions we use formally require ptr != NULL.
Can you have a look?
Regards, /Niels