Hello Niels, Do you plan a backport of the carry propagation fix in secp384 [0] for nettle 2.7.1? My limited understanding of the 3.2 assembly file wouldn't work out of the box in 2.7 due to the change from ecc_curve to ecc_modulus.
The fix for the secp256r1 issue [1] looks quite trivial to backport if p->m is replaced by ecc->p. Is my understanding correct?
regards, Nikos
[0]. https://git.lysator.liu.se/nettle/nettle/commit/fa269b6ad06dd13c90 1dbd84a12e52b918a09cd7
[1]. https://git.lysator.liu.se/nettle/nettle/commit/c71d2c9d20eeebb985 e3872e4550137209e3ce4d
On Tue, 09 Feb 2016 14:31:22 +0100 Nikos Mavrogiannopoulos nmav@redhat.com wrote:
Do you plan a backport of the carry propagation fix in secp384 [0] for nettle 2.7.1? My limited understanding of the 3.2 assembly file wouldn't work out of the box in 2.7 due to the change from ecc_curve to ecc_modulus.
The fix for the secp256r1 issue [1] looks quite trivial to backport if p->m is replaced by ecc->p. Is my understanding correct?
Debian has backported the patches already it seems: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813679
(Haven't checked them though)
Nikos Mavrogiannopoulos nmav@redhat.com writes:
Do you plan a backport of the carry propagation fix in secp384 [0] for nettle 2.7.1?
I hadn't planned to do that. Do you think I should?
My limited understanding of the 3.2 assembly file wouldn't work out of the box in 2.7 due to the change from ecc_curve to ecc_modulus.
I don't think that should be a problem, since the first argument to ecc_384_modp isn't used by the assembly implementation.
Hanno already pointed to the patches prepared by the debian maintainer. https://bugs.debian.org/cgi-bin/bugreport.cgi?msg=15;bug=813679;filename=net... (not yet available at https://sources.debian.net/src/nettle/2.7.1-5/debian/patches/, it seems).
Regards, /Niels
On Tue, 2016-02-09 at 15:52 +0100, Niels Möller wrote:
Do you plan a backport of the carry propagation fix in secp384 [0] for nettle 2.7.1?
I hadn't planned to do that. Do you think I should?
It's up to you. We plan to keep using this version of the library for quite long time.
My limited understanding of the 3.2 assembly file wouldn't work out of the box in 2.7 due to the change from ecc_curve to ecc_modulus.
I don't think that should be a problem, since the first argument to ecc_384_modp isn't used by the assembly implementation.
Hanno already pointed to the patches prepared by the debian maintainer. https://bugs.debian.org/cgi-bin/bugreport.cgi?msg=15;bug=813679;filen ame=nettle_2.7.1-5%2Bdeb8u1.debian.tar.xz;att=1 (not yet available at https://sources.debian.net/src/nettle/2.7.1-5/debian/patches/, it seems).
Thank you. One more thing on that. The Debian fix uses the new asm code under the LGPLv2+ license. Could I assume that you grant an exception for this file?
regards, Nikos
nettle-bugs@lists.lysator.liu.se
-
Hanno Böck -
Nikos Mavrogiannopoulos -
nisse＠lysator.liu.se