12 Apr
2019
12 Apr
'19
3:10 a.m.
On Fri, Apr 12, 2019 at 10:07 AM Niels Möller nisse@lysator.liu.se wrote:
However, looking at the code, I believe the allocation of memory is not required... it can be:
The if (hex_salt) {...} block overwrites the salt storage, for in-place hex decoding. I don't quite like overwriting the strings passed in via argv, even if it might be possible. So when I wrote this tool, always allocating a writable copy, and calling free unconditionally, seemed nice and easy,
Fair enough :)