nisse@lysator.liu.se (Niels Möller) writes:
Testing could be improved, quoting the comments in chacha-test.c:
/* FIXME: For rounds == 20, use crypt function, support more than one block, and test various short lengths. */
Done now. And I found and fixed one bug in chacha_crypt. When updating the block counter, it used the salsa20 state layout, not the chacha state layout.
And one more question on terminology and naming: Should it be chacha_set_nonce or chacha_set_iv?
I recently renamed salsa20_set_iv to salsa20_set_nonce, since "nonce" seemed to be the term most used in salsa20 literature.
Regards, /Niels