Re: Add AES Key Wrap (RFC 3394) in Nettle

Hello,

Le 2021-03-04 à 04 h 14, Niels Möller a écrit :

I've added a couple of comments on the mr.

Thanks a lot!

I still have one uresolved comment about byte swapping but the rest are resolved.

One question: Do you intentionally limit message size to 64 bytes? Is that according to spec?

Not at all. At first I thought AES key wrap had an input limit because it's about wrapping cypher keys, so to me the limit was 64 bytes. But even if it's the intention, I don't see any specific limitation on input message in the specs.

The only limitation is to have cyphertext 8 bytes longer than cleartext, and cleartext to be at least 16 bytes to be a set of 8-bytes blocks.

Therefore I removed 'uint8_t R[64]' to use TMP_GMP_DECL(R, uint8_t); instead.

/Nicolas