Re: cmac

Nikos Mavrogiannopoulos nmav@redhat.com writes:

On Wed, 2018-01-17 at 10:59 +0100, Nikos Mavrogiannopoulos wrote:

Following up on my patchset, this (hopefully final) version introduces CMAC with AES-256 as well. It also removes the CMAC128_KEY_SIZE definition as the key size only depends on the block algorithm used.

Thanks. I'm about to merge this, but it will probably take a day or two more.

+void cmac128_set_key(struct cmac128 *ctx, void *key,

•      nettle_cipher_func *encrypt);
  

I was a bit confused by "key" here, but it's the context struct of the underlying cipher? It should be const void *. In the ccm and eax code, it seems we use the name "cipher" for this, e.g.,

void eax_set_key (struct eax_key *key, const void *cipher, nettle_cipher_func *f);

Regards, /Niels