Gustavo Serra Scalet gustavo.scalet@eldorado.org.br writes:
Review points adjusted. See individual reviews on this separated branch:
https://git.lysator.liu.se/gut/nettle/commits/sha256-review
Points to be defined:
- Fill copyright owner:
https://git.lysator.liu.se/gut/nettle/commit/17e36f4e91d491ecc5a10ff1b567137...
This is a blocker. We don't do copyright assignments for nettle (mostly for historical reasons), and we definitely don't do any "contributor's license agreement"-silliness. But I still need to know origin of the code, preferable both who legally owns the copyright, and who actually wrote it.
- keep or tweak --enable-ppc-vector:
https://git.lysator.liu.se/gut/nettle/commit/d2371e2c4a469d6e9a3ffd9951662a4...
I think it makes sense to do something similar to --enable-arm-neon, with the default being adapting to the environment. Not sure if consulting /proc/cpuinfo is useful in this case, though, it may be sufficient to just check what the compiler or assembler accepts.
Or if all known ppc64el processors support it, maybe use of the vector instructions can be unconditional for that architecture.
Regards, /Niels