12 Jan
2018
12 Jan
'18
10:54 a.m.
On Fri, 2018-01-12 at 11:51 +0100, Nikos Mavrogiannopoulos wrote:
On Wed, 2018-01-10 at 11:24 +0100, Niels Möller wrote:
Nikos Mavrogiannopoulos nmav@redhat.com writes:
The attached patch brings support for AES-128-CMAC. The code is based on the samba code.
Nice. I think I'll have to read up a bit to understand what it's doing.
The rshift and lshift functions come from the AES implementation bundled with samba.
These to just a single bit right or left shift of a 16-byte block? To me it seems odd to do that with a table lookup for each byte.
Indeed, and I don't see any obvious benefit of that code. I've replaced it with a simpler version.
Re-sending as it seems I forgot to remove cmac-internal from makefile.
regards, Nikos