Maamoun TK maamoun.tk@googlemail.com writes:
Everything looks fine to me, I made an additional review and the code seems good for both endianness modes. The patches pass the testsuite on little-endian and big-endian (Thanks to Michael Weiser for providing a ready to go environment to test the patch on big-endian mode) I made one more patch that adds proper copyright and removes unused define.
Nice!
I've merged the easy parts, machine.m4 and README, onto the arm64 branch. Not crystal clear how the more interesting parts relate, though.
Is 0001-Mamone-s-unmodified-patch.patch the same as https://git.lysator.liu.se/nettle/nettle/-/merge_requests/13? Do you want to update the merge request with recent changes (on top of the current arm64 branch), or should I merge mr13 as is, and then add the other two patches (Michaels's BE support and this "adds proper copyright and removes unused define") on top?
Regards, /Niels