On Thu, 2013-12-26 at 22:00 +0100, Niels Möller wrote:
What result do you get with this test? Does it fail the assert, or does it exit successfuly when running without valgrind, but generate warnings/errors with valgrind?
It exits successfully but prints the valgrind warning (shown in the previous message).
The memxor-test.c in the repo tries to run memxor and memxor3 with all combinations of alignments and a selection of different sizes. And I get no warnings from
Do you get a warning after applying the patch? The alignment in the patch is exactly the same combination that causes the issue in the gnutls test cases, and seems to be dst:13, buf1:0, buf2:0.
In the memxor tests, do you put the buffers at a zone exactly at the ending position of the buffer, or there is some slack size at the end? In the latter case you'll not see any read past the boundary (though I see that you catch any write).
regards, Nikos