On Sun, 2017-11-05 at 23:42 +0100, Niels Möller wrote:
Nikos Mavrogiannopoulos nmav@redhat.com writes:
The changes seem good and backwards compatible. I haven't tested compiling gnutls or running its test suite though.
Let me know when you have been able to do that.
With the ABI and CFB changes now in, I think we're now in the testing phase before the release. I've updated the NEWS file (https://git.lysator.liu.se/nettle/nettle/blob/master/NEWS) and the release plan (http://www.lysator.liu.se/~nisse/nettle/plan.html).
Review of the NEWS file is appreciated.
Anything else which we should try to get in before release?
There is a run of it at (doesn't seem to compile):
https://gitlab.com/nmav/nettle/-/jobs/39216682
(if the intention was to be API compatible that breaks it, but if not, what would be your suggestion in handling that?)
I suggest including the attached patches to the CI. The first makes sure that random errors due to installation of fedora packages don't get in the way by using the pre-build images used in gnutls. The second it includes gnutls build in the CI to detect breakages early.
regards, Nikos