Hi Niels,
On 11/28/21 6:03 PM, Niels Möller wrote:
Tianjia Zhang tianjia.zhang@linux.alibaba.com writes:
You can refer to the ISO specification here: https://www.iso.org/standard/67116.html Or PDF version: https://github.com/alipay/tls13-sm-spec/blob/master/sm-en-pdfs/sm3/GBT.32905...
I see that RFC 8998 refers to http://www.gmbz.org.cn/upload/2018-07-24/1532401392982079739.pdf, which looks like the same pdf file. I find it a bit odd that the document carries no information on author or organization.
There is no author in the document, but the website www.gmbz.org.cn that publishes this standard is China’s Cryptography Standardization Technical Committee.
Thank you very much for your reminder, Jia Zhang is not himself, but another colleague of our team, I will add copyright information in the next version
The specification does not define the reference implementation of the algorithm. This series of patches mainly refers to the SM3 implementation in libgcrypt and gnulib.
It looks like the gcrypt implementation is licensed under LGPLv2.1 or later (see https://github.com/gpg/libgcrypt/blob/master/cipher/sm3.c), so should be fine to copy into nettle (in contrast to gnulib code, which appears to be GPLv3, and would need explicit permission from copyright holder before relicensing). But if it is a derived work of libgcrypt, in the sense of copyright law, the copyright header needs to acknowledge that, ie,
Copyright (C) 2017 Jia Zhang Copyright (C) 2021 Tianjia Zhang <tianjia.zhang@linux.alibaba.com>Or did you write both versions, with Jia being an alternate form of your name?
Thanks for pointing it out, Jia Zhang is another colleague of our team, I will add copyright information in the next version.
Best regards, Tianjia