On Tue, Jun 1, 2021 at 8:02 PM Niels Möller nisse@lysator.liu.se wrote:
Maamoun TK maamoun.tk@googlemail.com writes: If I read the latest patch correctly, you also don't keep any state besides the MSGx registers?
Right, everything is done in the same context of each round in the latest patch, nothing kept beyond or after.
the easiest solution is to define the data in the .text section to make sure the address is near enough to
be
loaded with certain instruction. Do you want to do that?
Using .text would probably work, even if it's in some sense more correct to put the constants in rodata segment. But let's leave as is for now.
I agree, it's acceptable to keep it as is for this case. I'm a little concerned about handling the constant initialization of more complicated cases, we're gonna discuss it at the time.
I've pushed the combined patches to a branch arm64-sha1. Would you like to update the fat build setup, before merging to master?
Sure, I just need some time as I have some stuff to sort out before doing the fat build for this patch.
regards, Mamone