Niels Möller píše v Út 02. 08. 2016 v 17:09 +0200:
Tomas Chvatal TChvatal@suse.com writes:
I noticed that some objects are compiled without cflags.
Was there any concrete problem?
See attached patch that fixes the situation. :)
I'm afraid it can break cross compilation. CFLAGS are for flags appropriate for the cross compiler. While the various programs built using $(CC_FOR_BUILD) are always native binaries. To be concrete, consider cross compiling for arm on a x86 build machine, and $(CFLAGS) choosen to select whether or not to enable generation of arm neon instructions. Passing those flags also to the native compiler won't work.
Regards, /Niels
Hello, we have checks that verify all objects are compiled with respecting cflags set in the distribution (hardening, optimization, etc.).
If there is object not doing that I get errors on it. Thus it should be able to do so.
Hmm with the cross-compilation I am not sure how that should be handled properly but simply ignoring all other cflags on those objects does not seem like right solution.
Tom