On Mon, 2018-03-19 at 23:08 +0100, Niels Möller wrote:
Nikos Mavrogiannopoulos n.mavrogiannopoulos@gmail.com writes:
It has but the detection is done through major and minor lib version. Are they updated?
Hmm, I'm looking at
https://gitlab.com/gnutls/gnutls/blob/master/lib/nettle/pk.c, line 1066:
#if NETTLE_MAJOR_VERSION < 3 || (NETTLE_MAJOR_VERSION == 3 && NETTLE_MINOR_VERSION < 4)
That should use the old symbols only prior to nettle-3.4, which seems correct, since the new accessors were introduced in nettle-3.4. But the rename-data-symbols branch also carries version 3.4, so the failure
https://gitlab.com/gnutls/nettle/-/jobs/57981115
is a bit strange. Maybe it's missing an #include <nettle/version.h> ?
That's very strange. bignum.h already includes version.h, so that should have been ok. I've also explicitly added it and re-run with the same results: https://gitlab.com/gnutls/nettle/-/jobs/58340605
What is even more strange is that gnutls in fedora is already using the new functions, and we got two bugs about it already: https://bugzilla.redhat.com/show_bug.cgi?id=1556890 https://bugzilla.redhat.com/show_bug.cgi?id=1549190
regards, Nikos