On Sun, 2016-07-17 at 12:14 +0200, Niels Möller wrote:
I'd like to eliminate pointer-signedness warnings. I'm afraid some ugly casts will have to be involved, since most functions work with uint8_t, and at least test code needs to pass literal strings, of type char *.
I have one question, on the ascii-armor funtions: Would ie make sense to change the type of ascii inputs and outputs to char? I.e.,
size_t base64_encode_update(struct base64_encode_ctx *ctx,
uint8_t *dst,
char *dst,size_t length, const uint8_t *src);
I think it would be good API-wise. I had to casted these parameters in almost every use I had for them.
not an ABI change for any ABI spec I'm aware of. What do you think?
As long as it doesn't break the ABI it's good to have such changes. It's less code to type to use these functions.
btw. Would you be interested in a patch which adds automatic x86-64 abi check via the CI? Something like:
https://gitlab.com/gnutls/gnutls/commit/99b4b7bb53f6d36ee991e2a2679776faf433...