Simon Josefsson simon@josefsson.org writes:
nisse@lysator.liu.se (Niels Möller) writes:
Thanks. Checked in now. Hope I got all the pieces.
Turned out I forgot to commit your test case. Fixed now.
I've also done the suggested reordering of the arguments (including the prototype in the manual).
Could you add that, or should I submit a patch?
A patch including tests and documentation would be very nice. Your prototype looks right to me,
void pbkdf2_hmac_sha1 (unsigned key_length, const uint8_t *key, unsigned iterations, unsigned salt_length, const uint8_t *salt, unsigned length, uint8_t *dst)
The declarations can go i pbkdf2.h, with implementation in separate source files pkbdf2-hmac-sha1.c and -sha256.c.
And I can now almost write "pbkdf2" correctly without thinking. Scary... ;-)
Regards, /Niels