On Wed, 2019-06-26 at 11:23 +0200, Niels Möller wrote:
Nikos Mavrogiannopoulos nmav@redhat.com writes:
The x86_64/sha_ni directory is not included in the distribution, and thus compilation fails when --enable-fat is provided. I update my previous patch to add `make distcheck` to include enable-fat, so that missing files from distribution are caught earlier.
Ouch. I'll have to make an updated release later today or tomorrow.
Thanks for finding it quickly. I've run at least a dozen of different tests on the rc1 tarball, but apparently none with x86_64 --enable-fat :-(
And problem is of course not limited to fat builds, it's just that --enable-fat happens to make it visible at compile time.
Niels, it may be nice to use gitlab and it's CI features to have tests with all configurations to catch these things.
Simo.