On Fri, 2018-06-08 at 13:34 +0200, Niels Möller wrote:
Nikos Mavrogiannopoulos nmav@redhat.com writes:
If you mean removing them from the public headers and placing them in one (or multiple) internal ones, it makes sense to me.
Sounds reasonable. Then it's harder to use them without realizing they're internal and not compatible over version changes (even though we ought to document the conventions).
What do you think? Are there any of the current _nettle_* symbols that should be in the advertised API (and hence renamed)?
I do not use any of them in gnutls, but searching at the debian code, I see: _nettle_md5_compress (sogo), _nettle_sha1_compress (filezilla/putty)
We could promote those to advertised ABI, then. I.e., linker symbols nettle_*_compress after the ABI change, while we could keep _nettle_*_compress as aliases in the header file, not not also break the API.
I attach the current state. It does move all internal symbols into multiple internal headers and removes them from exported list. The last patch renames _nettle_md5_compress and _nettle_sha1_compress and includes it into the exported list (quite ugly, maybe we skip that rename?).
regards, Nikos