Re: Potential bug in nettle-benchmark.c

Eli Zaretskii eliz@gnu.org writes:

This was flagged by GCC:

nettle-benchmark.c: In function 'time_cipher': nettle-benchmark.c:504:29: warning: argument to 'sizeof' in 'memset' call is the same expression as the destination; did you mean to provide an explicit length? [-Wsizeof-pointer-memaccess] memset(iv, 0, sizeof(iv));

Right, that memset call is broken. This should be fixed in the development version (there was a failed attempt to fix it back in february, which made it into the 3.0 release, and it was fixed properly a few months ago). Neither sizeof(iv) nor sizeof(*iv) is right, it should be cipher->block_size, the same size as was allocated a few lines up.

You are using nettle-2.7.1, I guess?

Regards, /Niels