Re: [PATCH] ecc-mod-arith.c: expose mpn_mul_n invariant violation

On Tue, Jul 18, 2017 at 4:57 PM, Niels Möller nisse@lysator.liu.se wrote:

Sergei Trofimovich slyfox@gentoo.org writes:

...

Overlap happens at a call of

    ecc_modp_mul (ecc, y3, B, z1);

which is basically

     mpn_mul_n (y3, B, z1, m->size),

I'm adding asserts to these functions, and then I can easily reproduce.

I think linking with a gmp configured with --enable-assert should be enough to catch the problem in a platform-independent way?

Nikos, is it easy to add that gmp config to one of the gitlab ci jobs? Alternatively, we could add the no-overlap asserts to mini-gmp, to catch it in mini-gmp builds.

Hi, I am using the mini-gmp build in gitlab due to some limitations of memory sanitizer with gmp. Thus, if the bundled version has these asserts it should result to an error.

regards, Nikos