6 Mar
2021
6 Mar
'21
7:08 p.m.
Hello again,
Le 2021-03-06 à 11 h 27, Niels Möller a écrit :
I've updated the MR to reuse ciphertext or cleartext as R. The original test cases still pass, I'll have to complete the tests.
Hmm. I think you should leave the input buffer untouched, with type const uint8_t*, and only use the *output* area for temporary storage.
In the in-place case, those will be the same and the code needs to handle that case, but if caller passes separate input and output buffers, the input should not be modified.
I feel ashamed for that one :p
I've reverted the changes to use the output buffer as the intermediate value instead.
/Nicolas