Re: [PATCH] Integration of chacha in Makefile.in

Joachim Strömbergson joachim@secworks.se writes:

Did you base the test program on the Salsa20 test program or my stuff?

I started with the testprogram in your git repo, but I don't think there's much left of that code now. I then added tests from your internet draft.

I can see if I can do (1).

That's already done... Try examples/nettle-benchmark chacha.

Testing could be improved, quoting the comments in chacha-test.c:

/* FIXME: For rounds == 20, use crypt function, support more than one block, and test various short lengths. */

For testing various lengths, one should also have a small redzone around the destination area, to check for overwrites.

Regards, /Niels