Nikos Mavrogiannopoulos n.mavrogiannopoulos@gmail.com writes:
Something that I just noticed is that chacha_poly1305_encrypt() returns a void value. However this function is limited to 2^32 data which is not really an expected upper bound.
At least the limit ought to be documented, and maybe backed up by an assert. I hesitate to add a return value for this.
Where do you see a 2^32 limit? If I remember this correctly, it uses chacha with 96 bit nonce and 32 bit counter, where counter 0 is used for key setup. So this limits the message size to (2^32-1)*64, appr. 250 GB. If there is any smaller limit, that's likely a bug.
Regards, /Niels