Re: Add AES Key Wrap (RFC 3394) in Nettle

On Tue, Feb 2, 2021 at 5:44 PM Nicolas Mora nicolas@babelouest.org wrote:

Hello,

I've added a merge request to implement AES key wrap and unwrap in Nettle [1].

The MR is not complete, because the tests haven't been pushed yet and the documentation is missing, but if the new functionality is welcome to Nettle, I'd rather have some feedback on the code first, to make sure it respects the project guidelines.

I can add tests based on the tests vectors in the RFC [2], but I'm not sure how the test suites are build, should I need to create test_wrap functions like in aes-test.c or something else?

One small comment... It may be useful to provide RFC 5469 Key Wrap. RFC 5469 provides a little more flexibility in the size of the secret being wrapped.

Jeff