Re: [PATCH v2 1/3] Add support for GOST GC256B curve

-- With best wishes Dmitry ср, 15 янв. 2020 г., 19:17 Niels Möller nisse@lysator.liu.se: > Dmitry Eremin-Solenikov dbaryshkov@gmail.com writes: > > >> > +const struct ecc_curve *nettle_get_gc256b(void) > >> > +{ > >> > + return &_nettle_gc256b; > >> > +} > >> > >> Would it make sense to add "gost" to this name, in similar position as > >> "secp" in other curves? > > > > I don't think so. Consider the names from "TLS Supported Groups" > registry. > > I still think it would be appropriate with some more context for the > Nettle name, just "gc256b" is a bit too terse and obscure. Try doing a > web search for it. Some alternatives: > > nettle_get_gost_gc256b > nettle_get_gost_curve_256b > nettle_get_tls_gc256b > > I can merge the support as is, but it would be good to agree on name > before release (and perhaps before adapting the gnutls code, to avoid > another renaming hassle there). > > Regards, > /Niels > > -- > Niels Möller. PGP-encrypted email is preferred. Keyid 368C6677. > Internet email is subject to wholesale government surveillance. >