Pike-devel

pike-devel@lists.lysator.liu.se

2 participants
3046 discussions

Win32: ERROR_DIRECTORY
by Martin Karlgren 10 Sep '14

10 Sep '14

Hey everybody, Shouldn't Windows' ERROR_DIRECTORY (267) code map to ENOTDIR? dosmaperr doesn't care about it for some reason, but still, it seems like a logical thing to do. Python does it since a couple of years (http://bugs.python.org/issue12802). set_errno_from_win32_error mentions winsock codes being passed through as-is though. What do you all think, is it likely that code depends on errno being ERROR_DIRECTORY in those cases? Do we need compat code for <= 7.8? Best regards, Marty -- Roxen Internet Software Martin Karlgren (Jonsson), Developer/Consultant Box 449, SE-581 05 Linköping, Sweden T: +46 13 376800 marty(a)roxen.com

2 1

IOBuffer questions
by Stephen R. van den Berg 10 Sep '14

10 Sep '14

Why do you keep io->this in the struct? Is it to avoid accessing the global Pike_fp->current_object ? -- Stephen.

2 3

Development discussion
by Peter Bortas 05 Sep '14

05 Sep '14

Arne was in Linköping yesterday, so we had an impromptu development discussion about whatever was on peoples minds. Here are my notes for further discussion: * discussion ** remove constant evaluation timelimit for recursive compilation ** timezone compilation is slow ** Calendars documentation is incomprehensable ** Release 8.0 *** Not stable right now *** Does Bill want to be the release master? *** Backend fails on MacOS. Misses events. ** Don't support HEARTBEAT in SSL on the server ** remove class equals (too many equals) ** lvalues are the bane of performance ** Testcases and a benchmark for SSL are needed ** No backups ** Move _stuff to Debug module? ** Disable portable bytecode storage per default It takes up a lot of the allocated storage at start. ** Use Unicode versions of file operations on Windows ** Writing to the registry on Windows would be nice ** Figure out what todo about char normalization on Unix *** UTF-8 be default everywhere ** remove hardcoded char-encoiding in ASN-1 ** Fix sprintf table modes to... add fewer spaces? ** Prevent gcc unrolling of syscall checks ** Make pike_interpreter thread local ** Pike tracing support for line coverage ** move frame allocation into interpreter ** Put random debugging stuff into a common cmod ** Reduce the number of efuns ** Also more efuns! Things that are called from c code and are fast. ** A way to get a human readable function name everywhere would be nice But perhaps not possible ** Remove old conpat stuff. Begin with stuff that is more than 10 years old. ** Fix computed goto? *shake* Things points to maybe on ARM ** Is arrays incorrectly addressed by pointer into moved array ** extend string buffer to be able to read from it ** Kill ADT.struct? ** callback id is 0, could it be something better? ** Crashes with AIDO and encode_value on large data sets with several threads ** Add new git committer -- Peter Bortas

6 14

Backport fix of program indexing
by Chris Angelico 05 Sep '14

05 Sep '14

This was fixed in 8.0 with commit afa24a, but not on 7.8. Is it okay to backport this fix? See branch rosuav/backport_program_indexing_fix which is cherry-picking that commit and fixing an insignificant merge conflict. Test case: constant foo="test"; int main() {write("%O\n",this_program["foo"]);} On 7.8, this fails with "Indexing on illegal type". ChrisA

1 0

NUL termination of strings in the string builder
by Stephen R. van den Berg 03 Sep '14

03 Sep '14

What is the rationale behind the implicit and forced NUL termination of strings that are in the process of being constructed in the string_builder? Where do we depend on this? Is it a byte-0 or is it a wchar-0 ? Is this solely to be able to pass non-finished string builder strings to UNIX system calls? Why not add the zero byte only when the shared string is finalised? I ask, obviously, because the code is literally *littered* with these NUL termination assignments, which, if they could be avoided would clear up a lot of superfluous cruft. -- Stephen.

1 0

Branches for discussion: Pango.Layout xy_to_char, Stdio.File nodelay
by Chris Angelico 28 Aug '14

28 Aug '14

Both of these have been discussed previously, but now they're posted as topic branches in the main repo. (I've also pushed a few non-controversial GTK2 changes to the 8.0 and 7.8 branches.) Branch: rosuav/pango_xy_to_char Adds a new method xy_to_char() to the GTK2.Pango.Layout object, parallel to xy_to_index(). It'll be slower, as it has to do more work, but it feels cleaner. Pike code constructs Pango layout objects using Unicode strings, not UTF-8, so getting back character indexes makes more sense than byte positions. Branch: rosuav/naglingcontrol Adds a new method nodelay() to Stdio.File to control the TCP_NODELAY flag. This is definitely debatable, as there's now starting to be more of a proliferation of flag-controlling methods. Would it be better to have a single method to set/reset flags? How should detection of available flags be done? (With the nodelay() method, the presence of the function implies its callability.) If this were Python, we'd have a lengthy python-ideas thread and probably a PEP to discuss this. :) Thoughts? ChrisA

2 2

Sql.pgsql behavior in case of errors
by aldem-pikedev＠aldem.net 21 Aug '14

21 Aug '14

Hi everyone, I am preparing to use Postgres in my app, found the following strange behavior: ---snip--- Sql.Sql db = Sql.Sql("pgsql://localhost", "test", "test", "test"); db->query("BEGIN"); db->query("INSERT INTO requests (SvTrId) VALUES ('lala')"); catch(db->query("INSERT INTO requests (SvTrId) VALUES ('lala')")); db->query("INSERT INTO requests (SvTrId) VALUES ('juju')"); db->query("ROLLBACK"); ---snip--- Database is opened, row with 'lala' is inserted, second query (obviously) fails as SvTrId is the primary key, but row with 'juju' is inserted *and* appears in the database - i.e. the transaction is *committed*! Studying source code show, that once error is encounter, session is reset, i.e. running transaction is rolled back, everything is closed, temporary tables are deleted and session variables are reset as well, and after that, the next statement(s) will be committed immediately, as there is no active transaction. In my opinion, this is not exactly correct behavior when statement fails, as session still may be needed (especially temporary tables, open cursors etc). Im some cases, this is perfectly normal when SQL statement fails, especially in SERIALIZED transaction isolation level, and it would be more practical to leave the decision as of what to do to the application. Yes, this is true that it is impossible to continue executing statements in failed transaction, but temporary tables etc. may still be needed. Also, silent reconnection is not a good idea too - when there are many transactional statements are executed - it would be nice to have an option to modify this behavior. Best regards, /Alexander

5 6

Re: zero_type of implicit return
by Chris Angelico 17 Aug '14

17 Aug '14

On Mon, Aug 18, 2014 at 7:15 AM, Mirar @ Pike developers forum <10353(a)lyskom.lysator.liu.se> wrote: > I can't imagine any code that relies on that a function not returning > anything is returning 0 and not UNDEFINED. Hmm. Actually, I think you're right. I do frequently make use of the implicit zero return, but never checking its zero_type. ChrisA

1 0

Re: zero_type of implicit return
by Chris Angelico 17 Aug '14

17 Aug '14

On Sun, Aug 17, 2014 at 3:15 AM, Martin Nilsson (Opera Mini - AFK!) @ Pike (-) developers forum <10353(a)lyskom.lysator.liu.se> wrote: > Would it make sense if the implicit return 0; in pike functions > had a different zero type than 0, like UNDEFINED? I'm conceptually okay with it, but it will break code. ChrisA

3 2

zero_type of implicit return
by Martin Nilsson (Opera Mini - AFK!) ＠ Pike (-) developers forum 16 Aug '14

16 Aug '14

Would it make sense if the implicit return 0; in pike functions had a different zero type than 0, like UNDEFINED?

2 1

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Pike-devel