Pike-devel

pike-devel@lists.lysator.liu.se

2 participants
3046 discussions

IOBuffer usability
by Martin Nilsson (Opera Mini - AFK!) ＠ Pike (-) developers forum 17 Sep '14

17 Sep '14

I changed part of the ASN1 decoder to use IOBuffer. Some comments - Stdio.IOBuffer is harder to type than ADT.struct. Can we rename it to Stdio.Buffer? There is already IO in Stdio. - get_ is shorter than read_. I'm on the fence on if this is a good change though. - read_buffer dosn't return Stdio.IOBuffer. An expression of type { IOBuffer = object } cannot be assigned to a variable of type { IOBuffer = object(implements _static_modules._Stdio()->IOBuffer) }. - It would be great if we could type cast() properly, so we can tell that (string)iobuffer is actually string(8bit).

2 3

Linux 3.13
by Martin Nilsson (Opera Mini - AFK!) ＠ Pike (-) developers forum 17 Sep '14

17 Sep '14

I've upgraded to Linux 3.13.0-34 and now the async_tls_close_test doesn't work anymore when called with 0 1 as parameters (blocking without clean close). Any ideas what to look for?

4 13

Refcounting gone wild?
by Stephen R. van den Berg 17 Sep '14

17 Sep '14

Is this to be expected? Why does it run up? > object c=Stdio.File(); > _refs(c); Result: 2 > c=c; Result: Stdio.File(0, 0, 777 /* fd=-1 */) > _refs(c); Result: 3 > c=c; Result: Stdio.File(0, 0, 777 /* fd=-1 */) > _refs(c); Result: 4 > -- Stephen.

5 4

IOBuffer vs. Buffer
by Stephen R. van den Berg 17 Sep '14

17 Sep '14

The actual reason I beefed up Buffer a bit lately is *because* I need to do some protocol decoding of a byte stream. Now I see IOBuffer arrive. In order to avoid code bloat, wouldn't it be a better idea to integrate the functionality of IOBuffer into Buffer and just keep one? Or is the performance difference so strikingly great that this sounds like a bad idea? -- Stephen.

5 16

configure tests
by Martin Nilsson (Opera Mini - AFK!) ＠ Pike (-) developers forum 17 Sep '14

17 Sep '14

Would it be reasonable to stop testing for functions defined in C89?

2 4

Does this fix a real bug?
by Stephen R. van den Berg 17 Sep '14

17 Sep '14

While "browsing" some code (what else to do with your spare time ;-), I find (not committed yet): commit e8716b0a9313e5c32b4dbf1d9c6246cad5a6b3b2 Author: Stephen R. van den Berg <srb(a)cuci.nl> Date: Mon Sep 1 11:31:36 2014 +0200 Store new malloced value instead. diff --git a/src/stralloc.c b/src/stralloc.c index 7cd709c..6ca0a02 100644 --- a/src/stralloc.c +++ b/src/stralloc.c @@ -3221,10 +3221,8 @@ PMOD_EXPORT void free_string_builder(struct string_builder *s) PMOD_EXPORT struct pike_string *finish_string_builder(struct string_builder *s) { ptrdiff_t len = s->s->len; - if (len != s->malloced) { - s->s->len = s->malloced; - s->s = realloc_unlinked_string(s->s, len); - } + if (len != s->malloced) + s->s = realloc_unlinked_string(s->s, s->malloced = len); else /* Ensure NUL-termination */ low_set_index(s->s,s->s->len,0); Am I just reading this wrong, or was the len/malloced assignment the wrong way around? And if yes, does this have any noticeable impact on the rest of the system? -- Stephen.

2 1

`<= vs `==
by Stephen R. van den Berg 17 Sep '14

17 Sep '14

It appears that when Pike is presented with a comparison like: a<=b And given the availability of `< and `<= and `== operators, it insists on using `< first, and if that fails it uses `==. Instead of using merely `<= directly. Am I missing something here or is that a missed optimisation? -- Stephen.

5 8

`<= vs `==
by Marcus Comstedt (ACROSS) (Hail Ilpalazzo!) ＠ Pike (-) developers forum 17 Sep '14

17 Sep '14

Either that, or add ``<, but then you haven't actually won anything.

1 0

When to use rawtypes?
by Stephen R. van den Berg 17 Sep '14

17 Sep '14

I notice that some methods of String.Buffer use rawtypes, others don't. When is a rawtype helpful and/or necessary? -- Stephen.

2 3

Removal of 7.2 compat broke Stdio.read_file
by Chris Angelico 17 Sep '14

17 Sep '14

Test case: int main() {write(Stdio.read_file("readfileboom.pike"));} Oddly enough, this works fine if run from a non-installed Pike: rosuav@sikorsky:~/pike$ bin/pike readfileboom.pike int main() {write(Stdio.read_file("readfileboom.pike"));} But installing it and using that causes a crash: rosuav@sikorsky:~/pike$ pike readfileboom.pike /home/rosuav/pike/src/cyclic.c:39: Fatal error: Unlink cyclic on lost cyclic struct. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Terminfo.pmod:920:Indexing on illegal type. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Terminfo.pmod:920:Got : zero. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Terminfo.pmod:920:Index : string(97..116). /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Terminfo.pmod:936:Placeholder already has storage! /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:220:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:220:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:220:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:279:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:279:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:279:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:289:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:289:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:289:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:299:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:299:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:299:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:321:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:321:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:321:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:406:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:406:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:406:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:1394:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:1394:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:1394:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:1437:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:1437:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:1437:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod.0:-: Warning: Compilation failed: Compilation failed. Backtrace at time of fatal: -:1: PikeCompiler("", UNDEFINED, -1, -1, target, placeholder)->compile() -:1: DefaultCompilerEnvironment->compile(PikeCompiler("", UNDEFINED, -1, -1, target, placeholder)) /usr/local/pike/8.0.3/lib/master.pike:790: compile_string("#pike __REAL_VERSION__\n\ninherit _Stdio;\n\n#ifdef "+[94107],"/usr/local/pike/8.0.3/lib/modules/Stdio.pmod/mod"+[9],0,object_program(Stdio),object(/usr/local/pike/8.0. 3/lib/modules/Stdio.pmod/module.pmod),UNDEFINED) /usr/local/pike/8.0.3/lib/master.pike:1533: master()->low_findprog("/usr/local/pike/8.0.3/lib/modules/Stdio.pmod/module.pmod","",0,1) /usr/local/pike/8.0.3/lib/master.pike:1656: master()->findprog("/usr/local/pike/8.0.3/lib/modules/Stdio.pmod/module.pmod",".pmod",0,1) /usr/local/pike/8.0.3/lib/master.pike:1690: master()->low_cast_to_program("/usr/local/pike/8.0.3/lib/modules/Stdio.pmod/module",0,0,1) /usr/local/pike/8.0.3/lib/master.pike:1939: master()->low_cast_to_object("/usr/local/pike/8.0.3/lib/modules/Stdio.pmod/module.pmod",0,0) /usr/local/pike/8.0.3/lib/master.pike:2157: Stdio->low_ind("module",1) /usr/local/pike/8.0.3/lib/master.pike:2074: Stdio->module_checker()->`!() /usr/local/pike/8.0.3/lib/master.pike:2214: Stdio->ind("read_file") /usr/local/pike/8.0.3/lib/master.pike:2256: Stdio->`[]("read_file") /usr/local/pike/8.0.3/lib/master.pike:2432: Stdio->ind("read_file") /usr/local/pike/8.0.3/lib/master.pike:2472: Stdio->`[]("read_file") -:1: PikeCompiler("", UNDEFINED, -1, -1, target, UNDEFINED)->compile() -:1: DefaultCompilerEnvironment->compile(PikeCompiler("", UNDEFINED, -1, -1, target, UNDEFINED)) /usr/local/pike/8.0.3/lib/master.pike:790: compile_string("int main() {write(Stdio.read_file(\"readfileboom.pike\"));}\n","/home/rosuav/pike/readfileboom.pike",UNDEFINED,/home/rosuav/pike/readfileboom,0,UNDEFINED) /usr/local/pike/8.0.3/lib/master.pike:1533: master()->low_findprog("/home/rosuav/pike/readfileboom",".pike",UNDEFINED,UNDEFINED) /usr/local/pike/8.0.3/lib/master.pike:1651: master()->findprog("/home/rosuav/pike/readfileboom",".pike",UNDEFINED,UNDEFINED) /usr/local/pike/8.0.3/lib/master.pike:1690: master()->low_cast_to_program("/home/rosuav/pike/readfileboom","/usr/local/pike/8.0.3/lib/master.pike",UNDEFINED,UNDEFINED) /usr/local/pike/8.0.3/lib/master.pike:1724: master()->cast_to_program("/home/rosuav/pike/readfileboom.pike","/usr/local/pike/8.0.3/lib/master.pike",UNDEFINED) Aborted The problem came in with commit ec8008 and its change to lib/master.pike.in - reverting that file (even without reverting the rest of the commit) cures the abort. This is amd64 Linux, and 'make clean' and 'make spotless' don't affect the crash. Seems peculiar that this should cause problems. ChrisA

2 1

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Pike-devel