Pike-devel July 2008

pike-devel@lists.lysator.liu.se

8 participants
41 discussions

Protocols.HTTP.http_encode_string
by Martin Stjernholm, Roxen IS ＠ Pike developers forum 22 Jul '08

22 Jul '08

I was just notified (crunch [bug 4560]) that Protocols.HTTP.http_encode_string doesn't work right for chars wider than 7 bits: According to RFCs 3986 (URI) and 3987 (IRI), chars should be utf-8 encoded followed by the http %XX encoding. http_encode_string instead leaves 8-bit chars unencoded and uses that strange %uXXXX encoding for wider chars, a form that has no grounds in standards at all as far as I've been able to tell. (Must say I'm curious where it comes from. A comment says it's some kind of Safari encoding. My limited googling suggests that Safari at least nowadays uses the RFC method.) The corresponding functions in Roxen have been corrected since 4.0. Encoding/decoding functions are always hazardous to change, so it's perhaps not an ideal time to do it right now. Otoh it would be rather nice to have correctly working functions in Pike instead of only in Roxen. So what do you say about changing it now?

4 28

getting warnings about unused public variables or functions
by Martin Bähr 20 Jul '08

20 Jul '08

hi, while refactoring some code today, i noticed how helpful the warnings about unused private variables or functions are. but it would have been even more helpful to optionally also have warnings (notices) about any unused items to be ableto find them easier and then decide if they are really needed. greetings, martin.

6 7

7.7/7.8 bugfix: Protocols.DNS_SD
by Bill Welliver 18 Jul '08

18 Jul '08

I commited a tiny bug fix for DNS_SD: the port argument is specified in network byte-order. There was no conversion in place, which means that folks using intel processors would get crazy registration addresses. Bill

1 0

Latest yellow dots
by Martin Stjernholm, Roxen IS ＠ Pike developers forum 18 Jul '08

18 Jul '08

Just a note regarding these: /home/mast/Pike/no-changes-7.7/src/testsuite.in:11: Test 9 (shift 0) (CRNL) failed (expected eval error). Got 0 1: mixed a() { (string) ({0x80000000}); } 2: /home/mast/Pike/no-changes-7.7/src/testsuite.in:13: Test 11 (shift 2) (CRNL) failed (expected eval error). Got 0 1: mixed a() { (string) ({-0x80000001}); } 2: The problem here is not the casting or that it doesn't throw an error as it should, but rather that the optimizer or pike_test.pike or something makes the error disappear.

2 3

Latest type checks
by Martin Stjernholm, Roxen IS ＠ Pike developers forum 17 Jul '08

17 Jul '08

Consider: class A { constant x = -1; string f() { return ([1: "foo"])[x] || "bar"; // Warning: Indexing on illegal type. Got int(-1..-1) } } class B { inherit A; constant x = 1; } int main() { werror ("%O\n", B()->f()); } This gives a warning on the indicated line. I guess the assumption is that x is constant there, but that's not necessarily true as the example shows. I guess the problem here again is that constants lack explicit types. If it was possible to type it then one would normally write "constant int x = -1;" and the situation wouldn't occur.

9 47

7.8 alpha 1
by Peter Bortas ＠ Pike developers forum 16 Jul '08

16 Jul '08

7.8 alpha 1, somewhat clumsily versioned 7.7.100 is avilable as http://pike.ida.liu.se/pub/pike/alpha/7.7.100/Pike-v7.7.100.tar.gz Known bugs preventing it from becoming a beta: * CHANGES is not complete. If you find any other bugs, lets hear it. Caveat emptor: I have not compile tested this tar-ball.

1 0

Pike 7.7: THIS_COMPILATION.lex
by H. William Welliver III 16 Jul '08

16 Jul '08

I'm testing a module on a recent 7.7 after using 7.7.34 for quite a while. I've run into a problem with some code that generates a program dynamically using start_new_program(). One of the first things that I do is add a constant using add_string_constant()., That's where the module dumps core. Apparently add_string_constant() and friends look at THIS_COMPILATION.lex and try to add strings based on the filename and such. Since I'm working with a C module, I'm not manipulating that, so I'm not sure how to get around it. Any suggestions? #0 store_prog_string (str=0x92a1ba10) at /Users/hww3/Downloads/Pike- v7.7-snapshot/src/program.c:6086 #1 0x000bac9a in add_constant (name=0x334560, c=0xbfffe1e8, flags=8) at /Users/hww3/Downloads/Pike-v7.7-snapshot/src/program.c:5179 #2 0x000bb0ef in simple_add_constant (name=0x5512d8 "\002", c=0x5512d8, flags=5575384) at /Users/hww3/Downloads/Pike-v7.7-snapshot/ src/program.c:5261 #3 0x000bb2bb in add_string_constant (name=0x5512d8 "\002", str=0x5512d8 "\002", flags=5575384) at /Users/hww3/Downloads/Pike-v7.7- snapshot/src/program.c:5333 The data in #3 and friends seems bogus, as the values I'm inserting in this example are string constants. Not sure if that's due to the problem that happens later or not. Bill

3 5

__depricate__ second and third argument to read_file
by Peter Bortas ＠ Pike developers forum 16 Jul '08

16 Jul '08

Going through my notes I noticed that we agreed to depricate the extra arguments to Stdio.read_file() to make way for a charset aware version in Pike 8. This has not been done. I suppose we don't really have to. The second argument will be a string or and object in the new charser version, in contrast to the current int. Opinions?

4 7

mktemp()
by Bill Welliver 16 Jul '08

16 Jul '08

I'll take a stab at mktemp; I was wondering though, if it was strictly necessary to use the system mktemp()... would a similarly functional pike based function work just as well? Where would it best be placed? Stdio? I can get it done shortly after a little guidance from the Pike style gods. Bill

6 10

make doc
by Peter Bortas ＠ Pike developers forum 16 Jul '08

16 Jul '08

New rule until 7.8 is shipped: Whenever you change documentation you MUST run "make doc" before checking it in.

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Pike-devel July 2008