Pike-devel September 2014

pike-devel@lists.lysator.liu.se

9 participants
31 discussions

Start a nNew thread

configure tests
by Martin Nilsson (Opera Mini - AFK!) ＠ Pike (-) developers forum 17 Sep '14

17 Sep '14

Would it be reasonable to stop testing for functions defined in C89?

2 4

Does this fix a real bug?
by Stephen R. van den Berg 17 Sep '14

17 Sep '14

While "browsing" some code (what else to do with your spare time ;-), I find (not committed yet): commit e8716b0a9313e5c32b4dbf1d9c6246cad5a6b3b2 Author: Stephen R. van den Berg <srb(a)cuci.nl> Date: Mon Sep 1 11:31:36 2014 +0200 Store new malloced value instead. diff --git a/src/stralloc.c b/src/stralloc.c index 7cd709c..6ca0a02 100644 --- a/src/stralloc.c +++ b/src/stralloc.c @@ -3221,10 +3221,8 @@ PMOD_EXPORT void free_string_builder(struct string_builder *s) PMOD_EXPORT struct pike_string *finish_string_builder(struct string_builder *s) { ptrdiff_t len = s->s->len; - if (len != s->malloced) { - s->s->len = s->malloced; - s->s = realloc_unlinked_string(s->s, len); - } + if (len != s->malloced) + s->s = realloc_unlinked_string(s->s, s->malloced = len); else /* Ensure NUL-termination */ low_set_index(s->s,s->s->len,0); Am I just reading this wrong, or was the len/malloced assignment the wrong way around? And if yes, does this have any noticeable impact on the rest of the system? -- Stephen.

2 1

`<= vs `==
by Stephen R. van den Berg 17 Sep '14

17 Sep '14

It appears that when Pike is presented with a comparison like: a<=b And given the availability of `< and `<= and `== operators, it insists on using `< first, and if that fails it uses `==. Instead of using merely `<= directly. Am I missing something here or is that a missed optimisation? -- Stephen.

5 8

`<= vs `==
by Marcus Comstedt (ACROSS) (Hail Ilpalazzo!) ＠ Pike (-) developers forum 17 Sep '14

17 Sep '14

Either that, or add ``<, but then you haven't actually won anything.

1 0

When to use rawtypes?
by Stephen R. van den Berg 17 Sep '14

17 Sep '14

I notice that some methods of String.Buffer use rawtypes, others don't. When is a rawtype helpful and/or necessary? -- Stephen.

2 3

Removal of 7.2 compat broke Stdio.read_file
by Chris Angelico 17 Sep '14

17 Sep '14

Test case: int main() {write(Stdio.read_file("readfileboom.pike"));} Oddly enough, this works fine if run from a non-installed Pike: rosuav@sikorsky:~/pike$ bin/pike readfileboom.pike int main() {write(Stdio.read_file("readfileboom.pike"));} But installing it and using that causes a crash: rosuav@sikorsky:~/pike$ pike readfileboom.pike /home/rosuav/pike/src/cyclic.c:39: Fatal error: Unlink cyclic on lost cyclic struct. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Terminfo.pmod:920:Indexing on illegal type. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Terminfo.pmod:920:Got : zero. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Terminfo.pmod:920:Index : string(97..116). /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Terminfo.pmod:936:Placeholder already has storage! /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:220:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:220:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:220:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:279:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:279:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:279:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:289:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:289:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:289:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:299:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:299:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:299:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:321:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:321:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:321:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:406:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:406:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:406:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:1394:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:1394:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:1394:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:1437:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:1437:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:1437:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod.0:-: Warning: Compilation failed: Compilation failed. Backtrace at time of fatal: -:1: PikeCompiler("", UNDEFINED, -1, -1, target, placeholder)->compile() -:1: DefaultCompilerEnvironment->compile(PikeCompiler("", UNDEFINED, -1, -1, target, placeholder)) /usr/local/pike/8.0.3/lib/master.pike:790: compile_string("#pike __REAL_VERSION__\n\ninherit _Stdio;\n\n#ifdef "+[94107],"/usr/local/pike/8.0.3/lib/modules/Stdio.pmod/mod"+[9],0,object_program(Stdio),object(/usr/local/pike/8.0. 3/lib/modules/Stdio.pmod/module.pmod),UNDEFINED) /usr/local/pike/8.0.3/lib/master.pike:1533: master()->low_findprog("/usr/local/pike/8.0.3/lib/modules/Stdio.pmod/module.pmod","",0,1) /usr/local/pike/8.0.3/lib/master.pike:1656: master()->findprog("/usr/local/pike/8.0.3/lib/modules/Stdio.pmod/module.pmod",".pmod",0,1) /usr/local/pike/8.0.3/lib/master.pike:1690: master()->low_cast_to_program("/usr/local/pike/8.0.3/lib/modules/Stdio.pmod/module",0,0,1) /usr/local/pike/8.0.3/lib/master.pike:1939: master()->low_cast_to_object("/usr/local/pike/8.0.3/lib/modules/Stdio.pmod/module.pmod",0,0) /usr/local/pike/8.0.3/lib/master.pike:2157: Stdio->low_ind("module",1) /usr/local/pike/8.0.3/lib/master.pike:2074: Stdio->module_checker()->`!() /usr/local/pike/8.0.3/lib/master.pike:2214: Stdio->ind("read_file") /usr/local/pike/8.0.3/lib/master.pike:2256: Stdio->`[]("read_file") /usr/local/pike/8.0.3/lib/master.pike:2432: Stdio->ind("read_file") /usr/local/pike/8.0.3/lib/master.pike:2472: Stdio->`[]("read_file") -:1: PikeCompiler("", UNDEFINED, -1, -1, target, UNDEFINED)->compile() -:1: DefaultCompilerEnvironment->compile(PikeCompiler("", UNDEFINED, -1, -1, target, UNDEFINED)) /usr/local/pike/8.0.3/lib/master.pike:790: compile_string("int main() {write(Stdio.read_file(\"readfileboom.pike\"));}\n","/home/rosuav/pike/readfileboom.pike",UNDEFINED,/home/rosuav/pike/readfileboom,0,UNDEFINED) /usr/local/pike/8.0.3/lib/master.pike:1533: master()->low_findprog("/home/rosuav/pike/readfileboom",".pike",UNDEFINED,UNDEFINED) /usr/local/pike/8.0.3/lib/master.pike:1651: master()->findprog("/home/rosuav/pike/readfileboom",".pike",UNDEFINED,UNDEFINED) /usr/local/pike/8.0.3/lib/master.pike:1690: master()->low_cast_to_program("/home/rosuav/pike/readfileboom","/usr/local/pike/8.0.3/lib/master.pike",UNDEFINED,UNDEFINED) /usr/local/pike/8.0.3/lib/master.pike:1724: master()->cast_to_program("/home/rosuav/pike/readfileboom.pike","/usr/local/pike/8.0.3/lib/master.pike",UNDEFINED) Aborted The problem came in with commit ec8008 and its change to lib/master.pike.in - reverting that file (even without reverting the rest of the commit) cures the abort. This is amd64 Linux, and 'make clean' and 'make spotless' don't affect the crash. Seems peculiar that this should cause problems. ChrisA

2 1

Win32: ERROR_DIRECTORY
by Martin Karlgren 10 Sep '14

10 Sep '14

Hey everybody, Shouldn't Windows' ERROR_DIRECTORY (267) code map to ENOTDIR? dosmaperr doesn't care about it for some reason, but still, it seems like a logical thing to do. Python does it since a couple of years (http://bugs.python.org/issue12802). set_errno_from_win32_error mentions winsock codes being passed through as-is though. What do you all think, is it likely that code depends on errno being ERROR_DIRECTORY in those cases? Do we need compat code for <= 7.8? Best regards, Marty -- Roxen Internet Software Martin Karlgren (Jonsson), Developer/Consultant Box 449, SE-581 05 Linköping, Sweden T: +46 13 376800 marty(a)roxen.com

2 1

IOBuffer questions
by Stephen R. van den Berg 10 Sep '14

10 Sep '14

Why do you keep io->this in the struct? Is it to avoid accessing the global Pike_fp->current_object ? -- Stephen.

2 3

Development discussion
by Peter Bortas 05 Sep '14

05 Sep '14

Arne was in Linköping yesterday, so we had an impromptu development discussion about whatever was on peoples minds. Here are my notes for further discussion: * discussion ** remove constant evaluation timelimit for recursive compilation ** timezone compilation is slow ** Calendars documentation is incomprehensable ** Release 8.0 *** Not stable right now *** Does Bill want to be the release master? *** Backend fails on MacOS. Misses events. ** Don't support HEARTBEAT in SSL on the server ** remove class equals (too many equals) ** lvalues are the bane of performance ** Testcases and a benchmark for SSL are needed ** No backups ** Move _stuff to Debug module? ** Disable portable bytecode storage per default It takes up a lot of the allocated storage at start. ** Use Unicode versions of file operations on Windows ** Writing to the registry on Windows would be nice ** Figure out what todo about char normalization on Unix *** UTF-8 be default everywhere ** remove hardcoded char-encoiding in ASN-1 ** Fix sprintf table modes to... add fewer spaces? ** Prevent gcc unrolling of syscall checks ** Make pike_interpreter thread local ** Pike tracing support for line coverage ** move frame allocation into interpreter ** Put random debugging stuff into a common cmod ** Reduce the number of efuns ** Also more efuns! Things that are called from c code and are fast. ** A way to get a human readable function name everywhere would be nice But perhaps not possible ** Remove old conpat stuff. Begin with stuff that is more than 10 years old. ** Fix computed goto? *shake* Things points to maybe on ARM ** Is arrays incorrectly addressed by pointer into moved array ** extend string buffer to be able to read from it ** Kill ADT.struct? ** callback id is 0, could it be something better? ** Crashes with AIDO and encode_value on large data sets with several threads ** Add new git committer -- Peter Bortas

6 14

Backport fix of program indexing
by Chris Angelico 05 Sep '14

05 Sep '14

This was fixed in 8.0 with commit afa24a, but not on 7.8. Is it okay to backport this fix? See branch rosuav/backport_program_indexing_fix which is cherry-picking that commit and fixing an insignificant merge conflict. Test case: constant foo="test"; int main() {write("%O\n",this_program["foo"]);} On 7.8, this fails with "Indexing on illegal type". ChrisA

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Pike-devel September 2014