Pike-devel August 2014

pike-devel@lists.lysator.liu.se

9 participants
31 discussions

When to use rawtypes?
by Stephen R. van den Berg 17 Sep '14

17 Sep '14

I notice that some methods of String.Buffer use rawtypes, others don't. When is a rawtype helpful and/or necessary? -- Stephen.

2 3

Removal of 7.2 compat broke Stdio.read_file
by Chris Angelico 17 Sep '14

17 Sep '14

Test case: int main() {write(Stdio.read_file("readfileboom.pike"));} Oddly enough, this works fine if run from a non-installed Pike: rosuav@sikorsky:~/pike$ bin/pike readfileboom.pike int main() {write(Stdio.read_file("readfileboom.pike"));} But installing it and using that causes a crash: rosuav@sikorsky:~/pike$ pike readfileboom.pike /home/rosuav/pike/src/cyclic.c:39: Fatal error: Unlink cyclic on lost cyclic struct. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Terminfo.pmod:920:Indexing on illegal type. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Terminfo.pmod:920:Got : zero. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Terminfo.pmod:920:Index : string(97..116). /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Terminfo.pmod:936:Placeholder already has storage! /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:220:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:220:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:220:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:279:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:279:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:279:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:289:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:289:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:289:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:299:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:299:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:299:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:321:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:321:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:321:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:406:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:406:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:406:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:1394:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:1394:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:1394:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:1437:Must return a value for a non-void function. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:1437:Expected: mixed. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod/Readline.pike:1437:Got : void. /usr/local/pike/8.0.3/lib/modules/Stdio.pmod.0:-: Warning: Compilation failed: Compilation failed. Backtrace at time of fatal: -:1: PikeCompiler("", UNDEFINED, -1, -1, target, placeholder)->compile() -:1: DefaultCompilerEnvironment->compile(PikeCompiler("", UNDEFINED, -1, -1, target, placeholder)) /usr/local/pike/8.0.3/lib/master.pike:790: compile_string("#pike __REAL_VERSION__\n\ninherit _Stdio;\n\n#ifdef "+[94107],"/usr/local/pike/8.0.3/lib/modules/Stdio.pmod/mod"+[9],0,object_program(Stdio),object(/usr/local/pike/8.0. 3/lib/modules/Stdio.pmod/module.pmod),UNDEFINED) /usr/local/pike/8.0.3/lib/master.pike:1533: master()->low_findprog("/usr/local/pike/8.0.3/lib/modules/Stdio.pmod/module.pmod","",0,1) /usr/local/pike/8.0.3/lib/master.pike:1656: master()->findprog("/usr/local/pike/8.0.3/lib/modules/Stdio.pmod/module.pmod",".pmod",0,1) /usr/local/pike/8.0.3/lib/master.pike:1690: master()->low_cast_to_program("/usr/local/pike/8.0.3/lib/modules/Stdio.pmod/module",0,0,1) /usr/local/pike/8.0.3/lib/master.pike:1939: master()->low_cast_to_object("/usr/local/pike/8.0.3/lib/modules/Stdio.pmod/module.pmod",0,0) /usr/local/pike/8.0.3/lib/master.pike:2157: Stdio->low_ind("module",1) /usr/local/pike/8.0.3/lib/master.pike:2074: Stdio->module_checker()->`!() /usr/local/pike/8.0.3/lib/master.pike:2214: Stdio->ind("read_file") /usr/local/pike/8.0.3/lib/master.pike:2256: Stdio->`[]("read_file") /usr/local/pike/8.0.3/lib/master.pike:2432: Stdio->ind("read_file") /usr/local/pike/8.0.3/lib/master.pike:2472: Stdio->`[]("read_file") -:1: PikeCompiler("", UNDEFINED, -1, -1, target, UNDEFINED)->compile() -:1: DefaultCompilerEnvironment->compile(PikeCompiler("", UNDEFINED, -1, -1, target, UNDEFINED)) /usr/local/pike/8.0.3/lib/master.pike:790: compile_string("int main() {write(Stdio.read_file(\"readfileboom.pike\"));}\n","/home/rosuav/pike/readfileboom.pike",UNDEFINED,/home/rosuav/pike/readfileboom,0,UNDEFINED) /usr/local/pike/8.0.3/lib/master.pike:1533: master()->low_findprog("/home/rosuav/pike/readfileboom",".pike",UNDEFINED,UNDEFINED) /usr/local/pike/8.0.3/lib/master.pike:1651: master()->findprog("/home/rosuav/pike/readfileboom",".pike",UNDEFINED,UNDEFINED) /usr/local/pike/8.0.3/lib/master.pike:1690: master()->low_cast_to_program("/home/rosuav/pike/readfileboom","/usr/local/pike/8.0.3/lib/master.pike",UNDEFINED,UNDEFINED) /usr/local/pike/8.0.3/lib/master.pike:1724: master()->cast_to_program("/home/rosuav/pike/readfileboom.pike","/usr/local/pike/8.0.3/lib/master.pike",UNDEFINED) Aborted The problem came in with commit ec8008 and its change to lib/master.pike.in - reverting that file (even without reverting the rest of the commit) cures the abort. This is amd64 Linux, and 'make clean' and 'make spotless' don't affect the crash. Seems peculiar that this should cause problems. ChrisA

2 1

Development discussion
by Peter Bortas 05 Sep '14

05 Sep '14

Arne was in Linköping yesterday, so we had an impromptu development discussion about whatever was on peoples minds. Here are my notes for further discussion: * discussion ** remove constant evaluation timelimit for recursive compilation ** timezone compilation is slow ** Calendars documentation is incomprehensable ** Release 8.0 *** Not stable right now *** Does Bill want to be the release master? *** Backend fails on MacOS. Misses events. ** Don't support HEARTBEAT in SSL on the server ** remove class equals (too many equals) ** lvalues are the bane of performance ** Testcases and a benchmark for SSL are needed ** No backups ** Move _stuff to Debug module? ** Disable portable bytecode storage per default It takes up a lot of the allocated storage at start. ** Use Unicode versions of file operations on Windows ** Writing to the registry on Windows would be nice ** Figure out what todo about char normalization on Unix *** UTF-8 be default everywhere ** remove hardcoded char-encoiding in ASN-1 ** Fix sprintf table modes to... add fewer spaces? ** Prevent gcc unrolling of syscall checks ** Make pike_interpreter thread local ** Pike tracing support for line coverage ** move frame allocation into interpreter ** Put random debugging stuff into a common cmod ** Reduce the number of efuns ** Also more efuns! Things that are called from c code and are fast. ** A way to get a human readable function name everywhere would be nice But perhaps not possible ** Remove old conpat stuff. Begin with stuff that is more than 10 years old. ** Fix computed goto? *shake* Things points to maybe on ARM ** Is arrays incorrectly addressed by pointer into moved array ** extend string buffer to be able to read from it ** Kill ADT.struct? ** callback id is 0, could it be something better? ** Crashes with AIDO and encode_value on large data sets with several threads ** Add new git committer -- Peter Bortas

6 14

Branches for discussion: Pango.Layout xy_to_char, Stdio.File nodelay
by Chris Angelico 28 Aug '14

28 Aug '14

Both of these have been discussed previously, but now they're posted as topic branches in the main repo. (I've also pushed a few non-controversial GTK2 changes to the 8.0 and 7.8 branches.) Branch: rosuav/pango_xy_to_char Adds a new method xy_to_char() to the GTK2.Pango.Layout object, parallel to xy_to_index(). It'll be slower, as it has to do more work, but it feels cleaner. Pike code constructs Pango layout objects using Unicode strings, not UTF-8, so getting back character indexes makes more sense than byte positions. Branch: rosuav/naglingcontrol Adds a new method nodelay() to Stdio.File to control the TCP_NODELAY flag. This is definitely debatable, as there's now starting to be more of a proliferation of flag-controlling methods. Would it be better to have a single method to set/reset flags? How should detection of available flags be done? (With the nodelay() method, the presence of the function implies its callability.) If this were Python, we'd have a lengthy python-ideas thread and probably a PEP to discuss this. :) Thoughts? ChrisA

2 2

Sql.pgsql behavior in case of errors
by aldem-pikedev＠aldem.net 21 Aug '14

21 Aug '14

Hi everyone, I am preparing to use Postgres in my app, found the following strange behavior: ---snip--- Sql.Sql db = Sql.Sql("pgsql://localhost", "test", "test", "test"); db->query("BEGIN"); db->query("INSERT INTO requests (SvTrId) VALUES ('lala')"); catch(db->query("INSERT INTO requests (SvTrId) VALUES ('lala')")); db->query("INSERT INTO requests (SvTrId) VALUES ('juju')"); db->query("ROLLBACK"); ---snip--- Database is opened, row with 'lala' is inserted, second query (obviously) fails as SvTrId is the primary key, but row with 'juju' is inserted *and* appears in the database - i.e. the transaction is *committed*! Studying source code show, that once error is encounter, session is reset, i.e. running transaction is rolled back, everything is closed, temporary tables are deleted and session variables are reset as well, and after that, the next statement(s) will be committed immediately, as there is no active transaction. In my opinion, this is not exactly correct behavior when statement fails, as session still may be needed (especially temporary tables, open cursors etc). Im some cases, this is perfectly normal when SQL statement fails, especially in SERIALIZED transaction isolation level, and it would be more practical to leave the decision as of what to do to the application. Yes, this is true that it is impossible to continue executing statements in failed transaction, but temporary tables etc. may still be needed. Also, silent reconnection is not a good idea too - when there are many transactional statements are executed - it would be nice to have an option to modify this behavior. Best regards, /Alexander

5 6

Re: zero_type of implicit return
by Chris Angelico 17 Aug '14

17 Aug '14

On Mon, Aug 18, 2014 at 7:15 AM, Mirar @ Pike developers forum <10353(a)lyskom.lysator.liu.se> wrote: > I can't imagine any code that relies on that a function not returning > anything is returning 0 and not UNDEFINED. Hmm. Actually, I think you're right. I do frequently make use of the implicit zero return, but never checking its zero_type. ChrisA

1 0

Re: zero_type of implicit return
by Chris Angelico 17 Aug '14

17 Aug '14

On Sun, Aug 17, 2014 at 3:15 AM, Martin Nilsson (Opera Mini - AFK!) @ Pike (-) developers forum <10353(a)lyskom.lysator.liu.se> wrote: > Would it make sense if the implicit return 0; in pike functions > had a different zero type than 0, like UNDEFINED? I'm conceptually okay with it, but it will break code. ChrisA

3 2

zero_type of implicit return
by Martin Nilsson (Opera Mini - AFK!) ＠ Pike (-) developers forum 16 Aug '14

16 Aug '14

Would it make sense if the implicit return 0; in pike functions had a different zero type than 0, like UNDEFINED?

2 1

Re: Development discussion
by Peter Bortas 15 Aug '14

15 Aug '14

On Thu, Aug 14, 2014 at 4:30 PM, Per Hedbor () @ Pike (-) developers forum <10353(a)lyskom.lysator.liu.se> wrote: >> ** remove class equals (too many equals) > > This somewhat obscure point is probably the existence of a whole bunch > of x [op]= op-codes (+=, -=, &=, %= etc) You brought it up, so however you define it is the correct definition. -- Peter Bortas

3 2

Re: Hilfe-crash.
by Chris Angelico 11 Aug '14

11 Aug '14

On Mon, Aug 11, 2014 at 4:20 AM, Martin Nilsson (Opera Mini - AFK!) @ Pike (-) developers forum <10353(a)lyskom.lysator.liu.se> wrote: > After the new code generation I get a consistent crash if I start > hilfe and does arrow up. Not very helpful backtrace though. It seems to depend on having a good-sized .hilfe_history. I was unable to reproduce the crash with no history, or with just a couple of lines. The crash happens as you describe if there are at least 9 lines in history; if there are exactly 8, then pressing up won't crash, but pressing down afterward will. Don't know if that helps at all or not. ChrisA

3 4

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Pike-devel August 2014