How about making a new 7.4 release this week? I've already taken the time to do the most boring part; updating CHANGES.
I'll just wait for Marcus update of configure to build in 7.5 xenofarm. Once it looks OK I'll backport it to 7.4 to get rid of the bc dependency. Then we are good to go from my perspective. What's the Win32 status?
/ Martin Nilsson (ja till euro, nej till cent)
Previous text:
2003-09-11 20:51: Subject: Pike 7.4.30
We could try.
/ Peter Bortas
I'd like to backport minor Calendar fixes too.
/ Johan Sundström, Lysator
Previous text:
2003-09-11 21:00: Subject: Pike 7.4.30
I'll just wait for Marcus update of configure to build in 7.5 xenofarm. Once it looks OK I'll backport it to 7.4 to get rid of the bc dependency. Then we are good to go from my perspective. What's the Win32 status?
/ Martin Nilsson (ja till euro, nej till cent)
I'd like to backport the openpt/grantpt stuff, if it works everywhere now.
/ Marcus Comstedt (ACROSS) (Hail Ilpalazzo!)
Previous text:
2003-09-11 21:00: Subject: Pike 7.4.30
I'll just wait for Marcus update of configure to build in 7.5 xenofarm. Once it looks OK I'll backport it to 7.4 to get rid of the bc dependency. Then we are good to go from my perspective. What's the Win32 status?
/ Martin Nilsson (ja till euro, nej till cent)
I suspect that will be one of the topics of the conference. I want _Crypto to be fully replaced with Nettle before 7.6. To be able to run the testsuite without valgrind-complaints is probably another good release-prerequisite.
/ Martin Nilsson (ja till euro, nej till cent)
Previous text:
2003-09-11 21:52: Subject: Pike 7.4.30
Will there be a 7.6 soon?
/ Mirar
Who is working on those issues?
/ Mirar
Previous text:
2003-09-11 21:58: Subject: Pike 7.4.30
I suspect that will be one of the topics of the conference. I want _Crypto to be fully replaced with Nettle before 7.6. To be able to run the testsuite without valgrind-complaints is probably another good release-prerequisite.
/ Martin Nilsson (ja till euro, nej till cent)
Should I commit the patch for iterators in foreach to 7.4 first? It's the compatibility issue that still irks me a bit, but maybe I'm overly sensitive.
/ Martin Stjernholm, Roxen IS
Previous text:
2003-09-11 20:42: Subject: Pike 7.4.30
How about making a new 7.4 release this week? I've already taken the time to do the most boring part; updating CHANGES.
/ Martin Nilsson (ja till euro, nej till cent)
Let's call it a bug fix and be done with it.
/ Martin Nilsson (ja till euro, nej till cent)
Previous text:
2003-09-11 21:03: Subject: Pike 7.4.30
Should I commit the patch for iterators in foreach to 7.4 first? It's the compatibility issue that still irks me a bit, but maybe I'm overly sensitive.
/ Martin Stjernholm, Roxen IS
I've got a patch to sslfile.pike which may be of interest. It solves a problem very similar to bug #2117 (lots of warnings for destructed files when running Roxen; in my case only reproducible using Safari on OS X) but I really don't know why.
Should I commit it to 7.4 and/or only 7.5? Anyone feeling responsible for this code and willing to dig into the actual reasons why the thread callbacks are mixed up?
Index: sslfile.pike =================================================================== RCS file: /pike/data/cvsroot/Pike/7.4/lib/modules/SSL.pmod/sslfile.pike,v retrieving revision 1.50 diff -u -r1.50 sslfile.pike --- sslfile.pike 29 Nov 2002 01:22:14 -0000 1.50 +++ sslfile.pike 12 Sep 2003 16:13:08 -0000 @@ -371,8 +371,13 @@ } }
+private Thread.Mutex write_mutex = Thread.Mutex(); + private void ssl_write_callback(mixed id) { + Thread.MutexKey mutex_key = write_mutex->lock(2); + if (!socket) return; + #ifdef SSL3_DEBUG werror(sprintf("SSL.sslfile->ssl_write_callback: handshake_finished = %d\n" "blocking = %d, write_callback = %O\n",
/ Jonas Walldén
Previous text:
2003-09-11 20:42: Subject: Pike 7.4.30
How about making a new 7.4 release this week? I've already taken the time to do the most boring part; updating CHANGES.
/ Martin Nilsson (ja till euro, nej till cent)
Since nobody objected I've committed my workaround to 7.2, 7.4 and 7.5. As stated in the log message this seems to be a case where the write callback gets called multiple times in separate threads with the same data. It sounds like a fundamental problem that may affect more than the SSL module.
(I should add that the Roxen server didn't run on OS X; it was a Solaris installation.)
/ Jonas Walldén
Previous text:
2003-09-12 18:20: Subject: Pike 7.4.30
I've got a patch to sslfile.pike which may be of interest. It solves a problem very similar to bug #2117 (lots of warnings for destructed files when running Roxen; in my case only reproducible using Safari on OS X) but I really don't know why.
Should I commit it to 7.4 and/or only 7.5? Anyone feeling responsible for this code and willing to dig into the actual reasons why the thread callbacks are mixed up?
Index: sslfile.pike
RCS file: /pike/data/cvsroot/Pike/7.4/lib/modules/SSL.pmod/sslfile.pike,v retrieving revision 1.50 diff -u -r1.50 sslfile.pike --- sslfile.pike 29 Nov 2002 01:22:14 -0000 1.50 +++ sslfile.pike 12 Sep 2003 16:13:08 -0000 @@ -371,8 +371,13 @@ } }
+private Thread.Mutex write_mutex = Thread.Mutex();
private void ssl_write_callback(mixed id) {
- Thread.MutexKey mutex_key = write_mutex->lock(2);
- if (!socket) return;
#ifdef SSL3_DEBUG werror(sprintf("SSL.sslfile->ssl_write_callback: handshake_finished = %d\n" "blocking = %d, write_callback = %O\n",
/ Jonas Walldén
pike-devel@lists.lysator.liu.se
-
Johan Sundstr�m, Lysator ＠ Pike developers forum -
Jonas Walld�n ＠ Pike developers forum
-
Marcus Comstedt (ACROSS) (Hail Ilpalazzo!) ＠ Pike (-) developers forum
-
Martin Baehr -
Martin Nilsson (ja till euro, nej till cent) ＠ Pike (-) developers forum
-
Martin Stjernholm, Roxen IS ＠ Pike developers forum
-
Mirar ＠ Pike developers forum
-
Peter Bortas ＠ Pike developers forum