Locale.Charset.ascii exists in 7.4 but is gone in 7.5. Is that intentional?
According to the log message, yes. I agree with grubba that it should not be accessible from the outside.
/ Martin Nilsson (lambda)
Previous text:
2003-05-24 00:08: Subject: Locale.Charset.ascii
Locale.Charset.ascii exists in 7.4 but is gone in 7.5. Is that intentional?
/ Martin Stjernholm, Roxen IS
Ok but it needs compatibility goo. At least rjb has started using it in his PiXTree module.
/ Martin Stjernholm, Roxen IS
Previous text:
2003-05-24 02:53: Subject: Locale.Charset.ascii
According to the log message, yes. I agree with grubba that it should not be accessible from the outside.
/ Martin Nilsson (lambda)
But the de-facto issue could just as well be solved by rjb ceasing to use the class, right?
/ Marcus Comstedt (ACROSS) (Hail Ilpalazzo!)
Previous text:
2003-05-24 12:14: Subject: Locale.Charset.ascii
I don't know. It's proven to be a de-facto compatibility issue, which I think is enough.
/ Martin Stjernholm, Roxen IS
If we could be sure that he's the only one, yes. But we can't.
/ Martin Stjernholm, Roxen IS
Previous text:
2003-05-24 12:18: Subject: Locale.Charset.ascii
But the de-facto issue could just as well be solved by rjb ceasing to use the class, right?
/ Marcus Comstedt (ACROSS) (Hail Ilpalazzo!)
The _de facto_ issue is that rjb used it. The rest is speculation. We could just as well speculate that somebody else is using some other totally internal class in some other module. I don't think we should have compatibility goo for things that should not be used by programs in the first place.
Using this particular class isn't even meaningful.
/ Marcus Comstedt (ACROSS) (Hail Ilpalazzo!)
Previous text:
2003-05-24 12:19: Subject: Locale.Charset.ascii
If we could be sure that he's the only one, yes. But we can't.
/ Martin Stjernholm, Roxen IS
Yes, if internal things that has been accessible from the outside disappear we better speculate that somebody is using them. It's a matter of threshold when compatibility goo becomes necessary. I'd say that if the thing hardly can be considered useful and if no reported use of it exists then it isn't necessary, but in this case we know it's used.
We can only blame the user if there's a comment or similar that says the thing is internal, but that isn't the case with the ascii class in 7.4. Given that autodoc comments overall still is fragmentary I don't think it's enough that the lack of such a comment is enough. I.e. I don't think rjb had bad judgement when he saw the class in the module and decided to use it.
/ Martin Stjernholm, Roxen IS
Previous text:
2003-05-24 12:22: Subject: Locale.Charset.ascii
The _de facto_ issue is that rjb used it. The rest is speculation. We could just as well speculate that somebody else is using some other totally internal class in some other module. I don't think we should have compatibility goo for things that should not be used by programs in the first place.
Using this particular class isn't even meaningful.
/ Marcus Comstedt (ACROSS) (Hail Ilpalazzo!)
At least to me, there is no issue with this particular class. I reference it only as a kludge to supress strict-type warnings, and the usage is #ifdef'd such the code should work in 7.5 too (but in truth I haven't tested for other possible incompatibilities, I don't have 7.5 installed yet).
/ rjb
Previous text:
2003-05-24 12:40: Subject: Locale.Charset.ascii
Yes, if internal things that has been accessible from the outside disappear we better speculate that somebody is using them. It's a matter of threshold when compatibility goo becomes necessary. I'd say that if the thing hardly can be considered useful and if no reported use of it exists then it isn't necessary, but in this case we know it's used.
We can only blame the user if there's a comment or similar that says the thing is internal, but that isn't the case with the ascii class in 7.4. Given that autodoc comments overall still is fragmentary I don't think it's enough that the lack of such a comment is enough. I.e. I don't think rjb had bad judgement when he saw the class in the module and decided to use it.
/ Martin Stjernholm, Roxen IS
pike-devel@lists.lysator.liu.se
-
Marcus Comstedt (ACROSS) (Hail Ilpalazzo!) ＠ Pike (-) developers forum -
Martin Nilsson (lambda) ＠ Pike (-) developers forum
-
Martin Stjernholm, Roxen IS ＠ Pike developers forum
-
rjb ＠ Pike developers forum