As a by-product of creating the Val.Timestamp (et al) types, I encountered numerous bugs and uncertainties in mktime() and System.TM() with regard to timezone handling/abuse.
AFAICS, all these bugs have now been dealt with and fixed in 8.1. Any objections if I port these fixes from 8.1 to 8.0?
It, incidentally, would allow us to git rid of some slow/undeterministic custom Pike-mktime() code (so the Pike footprint gets smaller, faster and deterministic with the fixes applied).
As a by-product of creating the Val.Timestamp (et al) types, I encountered numerous bugs and uncertainties in mktime() and System.TM() with regard to timezone handling/abuse.
AFAICS, all these bugs have now been dealt with and fixed in 8.1. Any objections if I port these fixes from 8.1 to 8.0?
Sounds good to me. No objection.
/grubba
Henrik Grubbstr?m (Lysator) @ Pike (-) developers forum wrote:
As a by-product of creating the Val.Timestamp (et al) types, I encountered numerous bugs and uncertainties in mktime() and System.TM() with regard to timezone handling/abuse.
Sounds good to me. No objection.
I rounded up the cleanups by Martin and dropped the fname argument as well, and ported the lot to 8.0.
I tried doing that with your bignum patch, but that resulted in a missing function in 8.0, so if that should be ported too, you please look into it.
pike-devel@lists.lysator.liu.se
-
Henrik Grubbstr�m (Lysator) ＠ Pike (-) developers forum -
Stephen R. van den Berg