On Thu, 2 May 2024 at 19:15, Henrik Grubbström (Lysator) @ Pike (-) developers forum 10353@lyskom.lysator.liu.se wrote:
Hi again Chris.
On Thu, 2 May 2024 at 17:58, Henrik Grubbström (Lysator) @ Pike (-) developers forum 10353@lyskom.lysator.liu.se wrote:
Does SSL.Port()->listen_fd() not work?
Inside HTTP.Server.Port, it kinda does, I think? I didn't run into any actual problems.
Inside HTTP.Server.SSLPort though, it doesn't, because omitting (or zeroing) the port number results in the default of 443 being used. So at best, you would have to pick a port and hope that it's not in use, listen on that, and then replace it with listen_fd(). I didn't try that but it seems rather inelegant.
Hmm... With your fixes, wouldn't it it work to just give an appropriate SSL.Port object to HTTP.Server.Port()? You would miss out on the generation of the default certificate, but otherwise it ought to behave the same.
Huh. That would be rather nice, if it works. Currently, the two codebases look pretty different. It would be rather neat if SSLPort could simply inherit Port and provide a default parameter.
ChrisA
pike-devel@lists.lysator.liu.se