I've committed a rough draft for CHANGES for the next stable. You are encouraged to fix the FIXME's either directly in CVS or by discussing them here and I'll commit something based on the discussion:
http://pike.ida.liu.se/development/cvs/diff.xml?module=Pike&file=7.8/CHA...
There are also two things that have to be resolved before I can make a build:
1) Protocols.IPv6
It really isn't a protocol module. Shouldn't that stuff be in Standards or Tools?
2) "Added symlink support to chown and utime"
I will read the code later, but perhaps someone can describe what _exactly_ that change is supposed to do? I've flagged it because changes of the follow-the-symlink kind has a well known tendency to blow up in the face.
chown and utime usually modifies the symlink target. That change adds an optional flag at the end, similar to stat(), to modify the symlink itself instead.
Right, those look completely sane and safe. I've cleared up everything I wanted now except the Protocols.IPv6 stuff. I don't have strong opinions about it, but I don't think the current location really makes sense. Unfortunately IPv4 stuff is not much help as an example since it's mostly efuns.
Oh, Protocols.IPv6 was my doing. Forgot that.
I put it there since IPv6 is, well, a protocol. Apparently you consider things in Protocols.pmod should be protocols in some more narrow sense?
IPv6 is a protocol, but what you have put there does not try to implement that protocol. In it's defence it puts some helpers there that I suppose might be used when implementing the protocol.
I think everything concerning a protocol should be in the same module. C.f. Protocols.pmod/HTTP.pmod/module.pmod that (among other things) contains a bunch of utility functions. Those functions don't implement the http protocol, still I don't think they belong in Standards.HTTP. That'd just be confusing.
In the case of IPv6 it's unlikely that protocol will ever be implemented as its own Pike module. Even so I think the same argument applies - it's a protocol and hence I expect to find IPv6-related stuff in Protocols.IPv6, just as I expect to find http-related stuff in Protocols.HTTP.
pike-devel@lists.lysator.liu.se
-
Martin Stjernholm, Roxen IS ＠ Pike developers forum -
Peter Bortas ＠ Pike developers forum