Anyone recently looked at pikefarm 7.7?
Something is going wrong with the testsuite. Most dots are yellow.
The failing test has to do (as far as I can see) with the LDAP tests, which should actually be skipped because ldap support wasn't build in.
Thnx,
Marc
In the last episode (Mar 13), Marc Dirix said:
Anyone recently looked at pikefarm 7.7?
Something is going wrong with the testsuite. Most dots are yellow.
The failing test has to do (as far as I can see) with the LDAP tests, which should actually be skipped because ldap support wasn't build in.
I'd guess the culprit is
RCS file: /cvs/Pike/7.7/lib/modules/Protocols.pmod/LDAP.pmod/client.pike,v revision 1.73 date: 2005/03/10 17:46:20; author: mast; state: Exp; lines: +24 -14 Made the parameters to client.compare() more sane and fixed it to actually work. Compatibility disregarded since it wasn't useful before this.
7.7/lib/7.2/modules/Protocols.pmod/LDAP.pmod/client.pike line 39 was not modified to match the new parameters.
Hmm, I only considered the likeliness for the function actually being used when I assessed the need for compatibility. I didn't think of blanket function wrappers.
Besides, the function was useful in its original form. It was the rewrite of the return values in 7.3 that made it useless.
Sorry, I forgot to check in one file in my fix for this. Should work now.
Pikefarm has gotten a lot of green dots now, at least. Aren't you confusing this with some other issue? I was talking about the 7.2 compat code for Protocols.LDAP.
pike-devel@lists.lysator.liu.se
-
Dan Nelson -
Marc Dirix -
Martin Nilsson (DivX Networks) ＠ Pike (-) developers forum -
Martin Stjernholm, Roxen IS ＠ Pike developers forum