This patch lets you do db->list_fields("schema.table") on Sql.postgres objects, which is needed if you have tables with the same names in different schemas. It also fixes the check for has_relexpires which wasn't using a valid SQL query.
Adam
You removed a c. from the first query. Was that intentional and will older versions still work with that change?
On Tue, 31 Jan 2006 23:35:11 +0000 (UTC) "Martin Nilsson (Opera Mini - AFK!) @ Pike (-) developers forum" 10353@lyskom.lysator.liu.se wrote:
You removed a c. from the first query. Was that intentional and will older versions still work with that change?
Yes, that query could never have worked, there is no table called c, and == isn't a valid operator. So it always throws an exception, and always sets relexpires to false. According to CVS that check was a "tentative" fix. I assume tentative because nobody had an ancient enough postgres server to test it with.
A better fix may be to remove that check altogether and always set "expires" to 0, since that's all its doing now anyways and that column isn't useful. The relexpires column was only used back in the postgres95 days, and even then it was only used by postgres itself for vacuuming. Wether or not its ok to remove "expires" from the mapping altogether is up to you, I'm not sure just how stable the 7.7 API is supposed to be, but removing it would only change the type of zero that gets returned.
Adam
pike-devel@lists.lysator.liu.se
-
Adam Montague -
Martin Nilsson (Opera Mini - AFK!) ＠ Pike (-) developers forum