No, that was a real bug.
Btw, you forgot to check the argument in take_fd. I fixed that.
/ Martin Stjernholm, Roxen IS
Previous text:
2004-07-02 11:57: Subject: Re: Two fd_boxes, same FD (Re: Drowning in the Shuffler (SEGV))
Stephen R. van den Berg wrote:
Martin Stjernholm, Roxen IS @ Pike developers forum wrote:
- The current Stdio code does not allow me to unhook the FD box temporarily, so fixing it from within http.pike is impossible.
Sorry for being a bit late in responding to this. I think it's an interface problem between the Fd class and Shuffler. The solution is to either take over the fd from the Fd object so that it temporarily becomes closed, or continue using the box directly in it.
Ok, I'll pick method one, I think.
Shuffler fixes, take four, are in. Per, mast, please review.
Also, I found an unrelated pop-bug in set_buffer, I believe (found it while trying to learn how the Pike stack works). Then again, maybe I don't understand what needs to be popped and pushed. -- Sincerely, srb@cuci.nl Stephen R. van den Berg (AKA BuGless). E-mails should be like a lady's skirt: Long enough to cover the subject, and short enough to be interesting.
/ Brevbäraren