I will clean it up a little bit and add some comments. However, I am traveling right now, so it will probably have to wait until next week. If noone complains until then, I will commit it into 7.9.
I would also propose to backport the XOR for float and 64bit integer in hash_svalue to 7.8.
On Sun, 27 Mar 2011, Martin Stjernholm, Roxen IS @ Pike developers forum wrote:
Nice work. I suspect a lot of the time in mapping tests written in pike is spent outside the hashing and bucket lookup functions themselves. I.e. a total increase of 10% implies that the core parts are quite a lot faster.
That's just my guess though. To really make a good comparison one would have to write tests in C, but that's not necessary to convince me. I think your patch looks good for 7.9.