hostname_cache bug in Query.pike

29 Jul 2008

Would it be possible for someone to sneak in this bugfix in Query.pike
at some stage?

--- lib/modules/Protocols.pmod/HTTP.pmod/Query.pike.old 2007-04-15 14:24:41.000000000 +0200
+++ lib/modules/Protocols.pmod/HTTP.pmod/Query.pike    2008-07-29 09:04:35.000000000 +0200
@@ -500,7 +500,9 @@
array hosts = (Protocols.DNS.client()->gethostbyname( hostname )||
                  ({ 0, 0 }))[1];
-   return sizeof(hosts) && hosts[random(sizeof( hosts ))];
+   return 
+     hostname_cache[hostname] =
+        ( sizeof(hosts) && hosts[random(sizeof( hosts ))] );
 }
to make the hostname_cache in Protocols.HTTP.Session work as intended.

    